shard: Update metric mode_info on Init #1174

acid-ant · 2024-06-13T07:13:51Z

acid-ant commented

2024-06-13 07:13:51 +00:00

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant force-pushed bugfix/upd-mode-metric-init from 3cfd8b1d28 to 2a85de6ddb

2024-06-13 07:15:39 +00:00

Compare

acid-ant requested review from storage-core-committers 2024-06-13 07:15:49 +00:00

acid-ant requested review from storage-core-developers 2024-06-13 07:15:53 +00:00

dstepanov-yadro approved these changes 2024-06-13 07:29:05 +00:00

fyrchik reviewed 2024-06-13 07:52:49 +00:00

pkg/local_object_storage/shard/shard.go

					
				@ -484,6 +484,7 @@ func (s *Shard) updateMetrics(ctx context.Context) {

						s.setContainerObjectsCount(contID.EncodeToString(), logical, count.Logic)

						s.setContainerObjectsCount(contID.EncodeToString(), user, count.User)

					}

					s.cfg.metricsWriter.SetMode(s.info.Mode)

fyrchik commented

2024-06-13 07:52:49 +00:00

All other methods check whether s.cfg.metricsWriter != nil, I suggest adding the check here too.

All other methods check whether `s.cfg.metricsWriter != nil`, I suggest adding the check here too.

acid-ant commented

2024-06-13 08:00:19 +00:00

It's done at the beginning of the method.

fyrchik marked this conversation as resolved

fyrchik reviewed 2024-06-13 07:55:26 +00:00

fyrchik left a comment

Could you also create a PR to support/v0.38 with this change?
It needs to be manually tested there separately.

Could you also create a PR to `support/v0.38` with this change? It needs to be manually tested there separately.

acid-ant commented

2024-06-13 08:02:28 +00:00

Could you also create a PR to support/v0.38 with this change?
It needs to be manually tested there separately.

Created #1175

> Could you also create a PR to `support/v0.38` with this change? > It needs to be manually tested there separately. Created https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1175

fyrchik approved these changes 2024-06-13 08:07:53 +00:00

fyrchik merged commit 68ac490729 into master

2024-06-13 08:33:06 +00:00

fyrchik referenced this pull request from a commit

2024-06-13 08:33:13 +00:00

[#1174] shard: Update metric `mode_info` on `Init`

fyrchik added this to the v0.41.0 milestone 2024-06-14 06:59:41 +00:00

Sign in to join this conversation.

No reviewers