TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

Add await flag to frostfs-cli control set-status command #1194

Merged
fyrchik merged 2 commits from dstepanov-yadro/frostfs-node:feat/control_set_status_await into master 2024-06-24 11:12:26 +00:00
Conversation 0 Commits 2 Files Changed 11
dstepanov-yadro commented 2024-06-20 13:09:52 +00:00
Collaborator

Output examples:

  • target status equals current status:
oot@dstepanov-node1[alone_datacenter]:~# /home/service/frostfs-cli-dstepanov --endpoint 127.0.0.1:8091 control set-status --status offline --wallet /etc/frostfs/storage/wallet.json --await
Enter password > 
Network status update request successfully sent.
Wait until epoch and netmap status change...
Netmap status changed to 'OFFLINE' successfully.
  • target status doesn't equal current status:
root@dstepanov-node1[alone_datacenter]:~# /home/service/frostfs-cli-dstepanov --endpoint 127.0.0.1:8091 control set-status --status offline --wallet /etc/frostfs/storage/wallet.json --await
Enter password > 
Network status update request successfully sent.
Wait until epoch and netmap status change...
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Current netmap status 'ONLINE', target status 'OFFLINE'
Epoch changed to 17
Netmap status changed to 'OFFLINE' successfully
Output examples: - target status equals current status: ``` oot@dstepanov-node1[alone_datacenter]:~# /home/service/frostfs-cli-dstepanov --endpoint 127.0.0.1:8091 control set-status --status offline --wallet /etc/frostfs/storage/wallet.json --await Enter password > Network status update request successfully sent. Wait until epoch and netmap status change... Netmap status changed to 'OFFLINE' successfully. ``` - target status doesn't equal current status: ``` root@dstepanov-node1[alone_datacenter]:~# /home/service/frostfs-cli-dstepanov --endpoint 127.0.0.1:8091 control set-status --status offline --wallet /etc/frostfs/storage/wallet.json --await Enter password > Network status update request successfully sent. Wait until epoch and netmap status change... Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Current netmap status 'ONLINE', target status 'OFFLINE' Epoch changed to 17 Netmap status changed to 'OFFLINE' successfully ```
dstepanov-yadro added 2 commits 2024-06-20 13:10:18 +00:00
9f9ab7a39b [#60] control: Add GetNetmapStatus method 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
DCO action / DCO (pull_request) Successful in 6m20s Details
Vulncheck / Vulncheck (pull_request) Successful in 8m7s Details
Tests and linters / gopls check (pull_request) Successful in 9m54s Details
Build / Build Components (1.21) (pull_request) Successful in 9m54s Details
Build / Build Components (1.22) (pull_request) Successful in 9m47s Details
Tests and linters / Lint (pull_request) Successful in 10m45s Details
Tests and linters / Staticcheck (pull_request) Successful in 12m1s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 11m33s Details
Tests and linters / Tests (1.22) (pull_request) Failing after 22m6s Details
Tests and linters / Tests (1.21) (pull_request) Failing after 24m19s Details
Tests and linters / Tests with -race (pull_request) Successful in 26m25s Details
0613c37368 [#60] cli: Add `await` flag to `control set-status` 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/control_set_status_await from 0613c37368 to ce8a13fb0f 2024-06-20 13:15:45 +00:00 Compare
dstepanov-yadro force-pushed feat/control_set_status_await from ce8a13fb0f to b86fbe230b 2024-06-20 13:20:21 +00:00 Compare
dstepanov-yadro force-pushed feat/control_set_status_await from b86fbe230b to aaaac37f24 2024-06-20 13:22:37 +00:00 Compare
dstepanov-yadro force-pushed feat/control_set_status_await from aaaac37f24 to 46732b61d7 2024-06-20 13:29:08 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-06-20 15:05:00 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-06-20 15:05:01 +00:00
dstepanov-yadro changed title from WIP: Add `await` flag to `frostfs-cli control set-status` command to Add `await` flag to `frostfs-cli control set-status` command 2024-06-20 15:05:12 +00:00
achuprov approved these changes 2024-06-24 07:08:18 +00:00
acid-ant approved these changes 2024-06-24 08:20:00 +00:00
aarifullin approved these changes 2024-06-24 10:56:33 +00:00
fyrchik merged commit 46732b61d7 into master 2024-06-24 11:12:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
acid-ant
aarifullin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1194
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:feat/control_set_status_await"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?