`frostfs-adm morph dump-hashes` panics when contacts are not deployed #1210

New Issue

Open

opened 2024-06-27 13:07:52 +00:00 by achuprov · 3 comments

achuprov commented

2024-06-27 13:07:52 +00:00

Collaborator

Current Behavior

 ./vendor/frostfs-adm morph dump-hashes -c "/home/achuprov/Documents/work/frostfs-dev-env/frostfs-adm.yml"
goroutine 1 [running]:
git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph/contract.dumpContractHashes(0x1a28c00, {0x100f34d?, 0x4?, 0x100f25d?})
        git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph/contract/dump_hashes.go:55 +0x1b1
github.com/spf13/cobra.(*Command).execute(0x1a28c00, {0xc0002b9c60, 0x2, 0x2})
        github.com/spf13/cobra@v1.8.0/command.go:983 +0xaca
github.com/spf13/cobra.(*Command).ExecuteC(0x1a25560)
        github.com/spf13/cobra@v1.8.0/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.8.0/command.go:1039
git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules.Execute(...)
        git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/root.go:50
main.main()
        git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/main.go:10 +0x1a

Steps to Reproduce (for bugs)

Insert the frostfs-adm before 2b6122192a/Makefile (L77)
Run make clean
Run make up

## Current Behavior  ``` ./vendor/frostfs-adm morph dump-hashes -c "/home/achuprov/Documents/work/frostfs-dev-env/frostfs-adm.yml" goroutine 1 [running]: git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph/contract.dumpContractHashes(0x1a28c00, {0x100f34d?, 0x4?, 0x100f25d?}) git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph/contract/dump_hashes.go:55 +0x1b1 github.com/spf13/cobra.(*Command).execute(0x1a28c00, {0xc0002b9c60, 0x2, 0x2}) github.com/spf13/cobra@v1.8.0/command.go:983 +0xaca github.com/spf13/cobra.(*Command).ExecuteC(0x1a25560) github.com/spf13/cobra@v1.8.0/command.go:1115 +0x3ff github.com/spf13/cobra.(*Command).Execute(...) github.com/spf13/cobra@v1.8.0/command.go:1039 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules.Execute(...) git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/root.go:50 main.main() git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/main.go:10 +0x1a ``` ## Steps to Reproduce (for bugs)  1. Insert the `frostfs-adm` before https://git.frostfs.info/TrueCloudLab/frostfs-dev-env/src/commit/2b6122192a4c26a84e6f8faa5533ab52fb2a88ef/Makefile#L77 1. Run `make clean` 2. Run `make up`

achuprov added the

bug

frostfs-adm

triage

labels 2024-06-27 13:07:52 +00:00

fyrchik commented

2024-06-27 13:16:39 +00:00

Owner

GetContractByID returns nil error and contract state in case contract is not deployed
The bug seems to be introduced during some of the last year dependency upgrade (likely actor refactoring while moving to v0.105)

In this task let's also check all other GetContractBy* invocations in code, we could have e.g. unexpected morph panic.

`GetContractByID` returns nil error and contract state in case contract is not deployed The bug seems to be introduced during some of the last year dependency upgrade (likely actor refactoring while moving to v0.105) In this task let's also check all other `GetContractBy*` invocations in code, we could have e.g. unexpected morph panic.

achuprov was assigned by fyrchik

2024-06-27 13:16:47 +00:00

fyrchik added this to the v0.42.0 milestone 2024-06-27 13:17:35 +00:00

fyrchik removed the

triage

label 2024-06-27 13:17:42 +00:00

fyrchik changed title from ~~frostfs-adm panics when contacts are not deployed~~ to `frostfs-adm morph dump-hashes` panics when contacts are not deployed

2024-06-27 13:28:42 +00:00

achuprov commented

2024-06-27 15:15:41 +00:00

Poster

Collaborator

The issue was triggered by this PR: https://github.com/nspcc-dev/neo-go/pull/3072.
@fyrchik Based on the tags, it appears to impact not only version 0.104.0, but also the support branches for earlier versions. Are we utilizing any of these branches?

The issue was triggered by this PR: https://github.com/nspcc-dev/neo-go/pull/3072. @fyrchik Based on the tags, it appears to impact not only version 0.104.0, but also the support branches for earlier versions. Are we utilizing any of these branches?

achuprov referenced a pull request that will close this issue

2024-06-27 16:30:37 +00:00

morph/GetContractByID: Fix error handling when contract not found #1211

fyrchik commented

2024-06-27 17:36:49 +00:00

Owner

@achuprov
The issue is minor and relates just to error reporting.
Not worth backporting anywhere.

@achuprov The issue is minor and relates just to error reporting. Not worth backporting anywhere.