blobstor: rewrite `TestIterate_IgnoreErrors()` #1215

New issue

Closed

opened 2024-07-01 14:54:27 +00:00 by elebedeva · 1 comment

elebedeva commented

2024-07-01 14:54:27 +00:00

Member

TestIterate_IgnoreErrors() here is commented out right now. There are lots of errors when the code is uncommented. I suggest to rewrite the test.

`TestIterate_IgnoreErrors()` [here](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/36eab4059c43af7f1d7f27b91cde85450a166dcb/pkg/local_object_storage/blobstor/iterate_test.go#L92) is commented out right now. There are lots of errors when the code is uncommented. I suggest to rewrite the test.

elebedeva added the

triage

internal

labels 2024-07-01 14:54:27 +00:00

fyrchik added the

frostfs-node

label 2024-07-02 11:39:35 +00:00

fyrchik commented

2024-07-02 12:02:09 +00:00

Owner

The test resides in the blobstor package, which uses common.Storage interface. We don't need to rely on fstree/blobovnicza and wrong permissions, but rather test that even if one of the storages has returned an error, we continue the iteration.

The behaviour of fstree and blobovnicza can be tested in their respective packages.

The test resides in the blobstor package, which uses `common.Storage` interface. We don't need to rely on fstree/blobovnicza and wrong permissions, but rather test that even if one of the storages has returned an error, we continue the iteration. The behaviour of fstree and blobovnicza can be tested in their respective packages.

fyrchik removed the

triage

label 2024-10-07 08:05:51 +00:00

fyrchik self-assigned this 2024-10-07 08:16:12 +00:00

fyrchik referenced this issue from a pull request that will close it,

2024-10-07 10:33:30 +00:00

blobstor/test: Cover iteration behaviour #1417

fyrchik referenced this issue from a commit

2024-10-07 12:44:29 +00:00

[#1215] blobstor/test: Cover iteration behaviour

fyrchik closed this issue

2024-10-07 12:44:34 +00:00