TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

Seal writecache async #1284

Merged
fyrchik merged 2 commits from dstepanov-yadro/frostfs-node:feat/writecache_seal_async into master 2024-09-04 19:51:10 +00:00
Conversation 2 Commits 2 Files changed 10 +113 -36
dstepanov-yadro commented 2024-07-31 13:35:27 +00:00
Member
Copy link

This PR makes it possible to seal writecache async (in background).

This PR makes it possible to seal writecache async (in background).
dstepanov-yadro force-pushed feat/writecache_seal_async from 1fad15aa87 to c828df5e1f 2024-07-31 13:52:14 +00:00 Compare
dstepanov-yadro reviewed 2024-07-31 13:56:18 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -102,0 +133,4 @@
if !m.NoMetabase() {
s.rb.Start(ctx, s.blobStor, s.metaBase, s.log)
}
s.writecacheSealCancel.Store(dummyCancel)
dstepanov-yadro commented 2024-07-31 13:56:18 +00:00
Author
Member
Copy link

To allow writecache seal only after Init

To allow writecache seal only after `Init`
dstepanov-yadro force-pushed feat/writecache_seal_async from c828df5e1f to 44975773a7 2024-08-06 07:53:39 +00:00 Compare
dstepanov-yadro reviewed 2024-08-06 07:56:59 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -102,0 +133,4 @@
if !m.NoMetabase() {
s.rb.Start(ctx, s.blobStor, s.metaBase, s.log)
}
s.writecacheSealCancel.Store(dummyCancel)
dstepanov-yadro commented 2024-08-06 07:56:59 +00:00
Author
Member
Copy link

Functional change. Other diff is just code refactor (method extract).

Functional change. Other diff is just code refactor (method extract).
dstepanov-yadro changed title from WIP: Seal writecache async to Seal writecache async 2024-08-06 08:01:33 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-08-06 08:01:39 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-08-06 08:01:39 +00:00
aarifullin reviewed 2024-08-06 08:59:21 +00:00
pkg/local_object_storage/shard/writecache.go Outdated
@ -78,1 +98,3 @@
defer s.m.RUnlock()
if p.sync() {
defer func() {
aarifullin commented 2024-08-06 08:59:21 +00:00
Member
Copy link

What do you think about this non-functional change:

cleanup := func() {
   s.m.RUnlock()
   s.writecacheSealCancel.Store(dummyCancel)
}

and use it in this line and below? :) Just make it little bit readable

What do you think about this non-functional change: ```go cleanup := func() { s.m.RUnlock() s.writecacheSealCancel.Store(dummyCancel) } ``` and use it in this line and below? :) Just make it little bit readable
dstepanov-yadro commented 2024-08-06 10:26:18 +00:00
Author
Member
Copy link

done

done
dstepanov-yadro force-pushed feat/writecache_seal_async from 44975773a7 to d824ee31be 2024-08-06 10:26:06 +00:00 Compare
fyrchik reviewed 2024-08-06 12:39:20 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -351,2 +359,4 @@
if s.hasWriteCache() {
prev := s.writecacheSealCancel.Swap(notInitializedCancel)
prev.cancel() // no need to wait: writecache.Seal and writecache.Close lock the same mutex
fyrchik commented 2024-08-06 08:47:39 +00:00
Owner
Copy link

Could you explain, how having the same mutex makes it ok not to wait?

Could you explain, how having the same mutex makes it ok not to wait?
dstepanov-yadro commented 2024-08-06 12:43:36 +00:00
Author
Member
Copy link

writecache.Close will wait for the writecache.Seal end.

`writecache.Close` will wait for the `writecache.Seal` end.
pkg/local_object_storage/shard/writecache.go Outdated
@ -79,0 +101,4 @@
s.writecacheSealCancel.Store(dummyCancel)
}
if p.sync() {
fyrchik commented 2024-08-06 12:39:16 +00:00
Owner
Copy link

To me it makes reading harder: here it is p.sync(), below p.Async, I needed to look at p.sync definition to see if they correspond to the same thing.

To me it makes reading harder: here it is `p.sync()`, below `p.Async`, I needed to look at `p.sync` definition to see if they correspond to the same thing.
dstepanov-yadro commented 2024-08-06 12:52:46 +00:00
Author
Member
Copy link

A controversial statement, but fixed.

A controversial statement, but fixed.
dstepanov-yadro force-pushed feat/writecache_seal_async from d824ee31be to 33823f984b 2024-08-06 12:50:53 +00:00 Compare
acid-ant approved these changes 2024-08-06 13:34:01 +00:00
fyrchik reviewed 2024-08-07 08:09:07 +00:00
pkg/local_object_storage/shard/writecache.go Outdated
@ -86,1 +116,4 @@
defer cleanup()
s.log.Info(logs.StartedWritecacheSealAsync)
if err := s.writeCache.Seal(context.WithoutCancel(ctx), p.IgnoreErrors); err != nil {
fyrchik commented 2024-08-07 08:09:05 +00:00
Owner
Copy link

Is seal uncancellable?

Is `seal` uncancellable?
dstepanov-yadro commented 2024-08-07 08:16:56 +00:00
Author
Member
Copy link

fixed

fixed
dstepanov-yadro force-pushed feat/writecache_seal_async from 33823f984b to bf8919333e 2024-08-07 08:16:45 +00:00 Compare
acid-ant approved these changes 2024-08-07 09:23:34 +00:00
fyrchik commented 2024-08-09 06:28:56 +00:00
Owner
Copy link

please, rebase

please, rebase
dstepanov-yadro force-pushed feat/writecache_seal_async from bf8919333e to 0dcc5e75e0 2024-08-09 07:50:25 +00:00 Compare
dstepanov-yadro commented 2024-08-09 07:50:35 +00:00
Author
Member
Copy link

please, rebase

done

> please, rebase done
acid-ant approved these changes 2024-08-09 08:31:23 +00:00
aarifullin approved these changes 2024-08-09 09:02:18 +00:00
fyrchik reviewed 2024-08-09 10:13:25 +00:00
pkg/local_object_storage/shard/writecache.go Outdated
@ -83,2 +110,4 @@
defer cleanup()
}
if s.info.Mode.ReadOnly() {
fyrchik commented 2024-08-09 10:12:58 +00:00
Owner
Copy link

If p.Async == true && s.info.Mode.ReadOnly() we will have non-dummy canceler in writecacheSealCancel and it won't be called on exit.
It this intentional?

If `p.Async == true && s.info.Mode.ReadOnly()` we will have non-dummy canceler in `writecacheSealCancel` and it won't be called on exit. It this intentional?
dstepanov-yadro commented 2024-08-09 10:24:09 +00:00
Author
Member
Copy link

Shame on me! Thx! Fixed.

Shame on me! Thx! Fixed.
dstepanov-yadro force-pushed feat/writecache_seal_async from 0dcc5e75e0 to 80ce7c3a00 2024-08-09 10:23:55 +00:00 Compare
fyrchik approved these changes 2024-08-09 10:42:19 +00:00
dstepanov-yadro requested review from aarifullin 2024-08-09 11:16:18 +00:00
dstepanov-yadro requested review from acid-ant 2024-08-09 11:16:22 +00:00
acid-ant approved these changes 2024-08-09 12:38:48 +00:00
fyrchik referenced this pull request from a commit 2024-08-09 12:46:28 +00:00
[#1284] shard: Resolve funlen linter
fyrchik merged commit 80ce7c3a00 into master 2024-08-09 12:46:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1284
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/writecache_seal_async"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?