adm/morph: Support global unique domains #1301
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1301
Loading…
Reference in a new issue
No description provided.
Delete branch "achuprov/frostfs-node:feat/global_domain"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In this PR
frostfs-adm morph nns delete
-v
tofrostfs-adm morph nns tokens
Ref: TrueCloudLab/frostfs-contract#102
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com
@ -7,2 +7,4 @@
)
const (
longFormat = "long"
This comment is not a change request but haven't you considered
-v, --verbose
flag for this purpose? :)You’re right, that would be better. Initially, I wanted to do it like
ls -l
.2283b5c08c
to80f6c38dc6
@ -7,2 +11,4 @@
)
const (
verboseLong = "verbose"
We already have such flag here
80f6c38dc6
to05f92f2901
@ -20,2 +29,3 @@
for _, token := range toks {
cmd.Println(string(token))
output := string(token)
if longFlag, err := cmd.Flags().GetBool(commonflags.Verbose); err == nil && longFlag {
Let's skip checking for error at all:
fixed
@ -25,0 +40,4 @@
func getCnameRecord(c *client.Contract, token []byte) string {
items, err := c.GetRecords(string(token), big.NewInt(int64(nns.CNAME)))
if err != nil {
Why this error should not important for us?
You are right; only one type of error is considered valid
@ -7,2 +11,4 @@
)
const (
verboseDesc = "Includes additional information about CNAME record."
Includes
->Include
@ -25,0 +41,4 @@
func getCnameRecord(c *client.Contract, token []byte) string {
items, err := c.GetRecords(string(token), big.NewInt(int64(nns.CNAME)))
if err != nil {
return ""
The error should be reported, otherwise, we cannot rely on the output.
05f92f2901
to89d0435b1d
New commits pushed, approval review dismissed automatically according to repository settings
e5ad46ca80
to32845c1814
adm/morph: Support global domainto adm/morph: Support global unique domains@ -25,0 +43,4 @@
func getCnameRecord(c *client.Contract, token []byte) (string, error) {
items, err := c.GetRecords(string(token), big.NewInt(int64(nns.CNAME)))
if err != nil && strings.Contains(err.Error(), "not an array") {
Could you explain when does this error occur?
A comment would be helpful.
fixed
32845c1814
to4632a3d2ff
4632a3d2ff
to5e9880037f
5e9880037f
to7f145897a8
7f145897a8
toe56cdd94e0
⬆️Add
frostfs-adm morph nns delete
⬆️e56cdd94e0
tof8fea4f994
New commits pushed, approval review dismissed automatically according to repository settings
f8fea4f994
to7b295f826a
7b295f826a
to29a1574969
29a1574969
to53a90634fc