Move target initialization for `Put` operation to common package #1310

New issue

Closed

opened 2024-08-13 13:39:19 +00:00 by aarifullin · 0 comments

aarifullin commented

2024-08-13 13:39:19 +00:00

Member

Patch method that was introduced in #1307 merges two streams (patches and intact original object payload chunks) into one. The result of patching is saved to FrostFS by using Put.

In this case, the save mechanism for Patch method must not differ from Put. That's why Patch currently uses a trick by initializing putStream using pkg/service/object/put/streamer.go and accessing target required for patcher initilazation (it recieves ObjectWriter) but this breaks encapsulation (see this discussion) to reach put mechanism consistency.

It is required to move target initialization for both PutStream and Patch to one common package and then reuse it:

We'll save the encapsulation
Put mechanism will be consistent between Put and Patch

`Patch` method that was introduced in [#1307](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1307) merges two streams (patches and intact original object payload chunks) into one. The result of patching is saved to `FrostFS` by using `Put`. In this case, the save mechanism for `Patch` method must not differ from `Put`. That's why `Patch` currently uses a trick by initializing `putStream` using `pkg/service/object/put/streamer.go` and accessing target required for `patcher` initilazation (it recieves `ObjectWriter`) but this breaks encapsulation (see [this discussion](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1307#issuecomment-47188)) to reach put mechanism consistency. It is required to move target initialization for both `PutStream` and `Patch` to one common package and then reuse it: 1. We'll save the encapsulation 2. Put mechanism will be consistent between `Put` and `Patch`