TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Fix pilorama sorted listing, support/v0.42 #1328

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:fix-pochtabank-160 into support/v0.42 2024-09-04 19:51:11 +00:00
Conversation 0 Commits 1 Files changed 3 +32 -10
fyrchik commented 2024-08-23 10:22:31 +00:00
Owner
Copy link

There is a problem for a specific set of object names.
We need to have many objects with different lengths of a name.

There is a problem for a specific set of object names. We need to have many objects with different lengths of a name.
fyrchik added 2 commits 2024-08-23 10:22:37 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
pilorama: Do not skip items in SortedByFilename
Some checks failed
DCO action / DCO (pull_request) Failing after 52s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m48s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 4m18s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m30s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 4m16s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m59s
Details
Tests and linters / Lint (pull_request) Successful in 5m5s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m3s
Details
Tests and linters / gopls check (pull_request) Successful in 5m10s
Details
Build / Build Components (1.22) (pull_request) Successful in 5m6s
Details
Build / Build Components (1.21) (pull_request) Successful in 5m9s
Details
7c3e376f80 
Benchmark results:
```
goos: linux
goarch: amd64
pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/pilorama
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
                                   │     old     │                 new                 │
                                   │   sec/op    │   sec/op     vs base                │
ForestSortedIteration/bbolt,root-8   207.2µ ± 6%   173.6µ ± 6%  -16.23% (p=0.000 n=10)
ForestSortedIteration/bbolt,leaf-8   3.910µ ± 5%   3.928µ ± 7%        ~ (p=0.529 n=10)
geomean                              28.46µ        26.11µ        -8.27%
```

They are not representative, as the worst case is when we have multiple
items of different lengths. However, `FileName` is usually less than 100
in practice, so the asymptotics is the same.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-08-23 10:22:44 +00:00
fyrchik requested review from storage-core-developers 2024-08-23 10:22:45 +00:00
fyrchik added the
P1
 label 2024-08-23 10:22:51 +00:00
fyrchik added this to the v0.43.0 milestone 2024-08-23 10:22:52 +00:00
fyrchik modified the milestone from v0.43.0 to v0.42.0 2024-08-23 10:22:57 +00:00
fyrchik force-pushed fix-pochtabank-160 from 7c3e376f80 to a492a7a61a 2024-08-23 10:23:24 +00:00 Compare
dstepanov-yadro approved these changes 2024-08-23 10:33:26 +00:00
fyrchik force-pushed fix-pochtabank-160 from a492a7a61a to 01e18eda43 2024-08-23 10:41:08 +00:00 Compare
fyrchik added the
bug
 label 2024-08-23 10:53:33 +00:00
acid-ant approved these changes 2024-08-23 10:56:03 +00:00
fyrchik merged commit 01e18eda43 into support/v0.42 2024-08-26 06:11:45 +00:00
fyrchik deleted branch fix-pochtabank-160 2024-08-26 06:11:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.42.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1328
No description provided.
Delete branch "fyrchik/frostfs-node:fix-pochtabank-160"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?