Fix Patch handler bugs #1338

aarifullin · 2024-08-27T13:12:01Z

aarifullin commented

2024-08-27 13:12:01 +00:00

Fix range provider in Patch handler: handle specific range with .offset = payload_length and length = 0
Fix audit patch stream

- Fix range provider in `Patch` handler: handle specific range with `.offset = payload_length` and `length = 0` - Fix audit patch stream

aarifullin added the

bug

label 2024-08-27 13:12:01 +00:00

aarifullin requested review from storage-core-committers 2024-08-27 13:12:21 +00:00

aarifullin requested review from storage-core-developers 2024-08-27 13:12:24 +00:00

fyrchik reviewed 2024-08-27 13:15:30 +00:00

pkg/services/object/audit.go Outdated

					
				@ -204,7 +204,7 @@ func (a *auditPatchStream) CloseAndRecv(ctx context.Context) (*object.PatchRespo

					if err != nil {

						a.failed = true

					}

					a.objectID = resp.GetBody().ObjectID

fyrchik commented

2024-08-27 13:14:18 +00:00

I am wondering why protogetter linter hasn't catched this.

I am wondering why `protogetter` linter hasn't catched this.

👀 1

fyrchik marked this conversation as resolved

pkg/services/object/patch/range_provider.go Outdated

					
				@ -32,1 +34,4 @@

				func (r *rangeProvider) GetRange(ctx context.Context, rng *objectSDK.Range) io.Reader {

					// Remote GetRange request to a container node uses an SDK-client that fails range validation

					// with zero-length. However, from the patcher's point of view, such request is still valid.

					if rng.GetOffset() == r.originalPayloadLength && rng.GetLength() == 0 {