TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 94 Pull requests 3 Projects Releases 1 Activity Actions

shard: Fix TestGCDropsObjectInhumedFromWritecache flaky test #1346

Merged
fyrchik merged 1 commit from a-savchuk/frostfs-node:bugfix/1320-shard-rebuild-flaky-test into master 2024-09-02 07:45:16 +00:00
Conversation 1 Commits 1 Files changed 3 +13 -3
a-savchuk commented 2024-09-01 21:51:18 +00:00
Member
Copy link

Close #1320

The TestGCDropsObjectInhumedFromWritecache test was flaky because a running asynchronous rebuild operation prevented GC from deleting the object. A test-only shard option WithDisabledRebuild has been added to fix this.

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Close #1320 The `TestGCDropsObjectInhumedFromWritecache` test was flaky because a running asynchronous rebuild operation prevented GC from deleting the object. A test-only shard option `WithDisabledRebuild` has been added to fix this. Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-01 21:51:28 +00:00
[#1320] test: Fix flaky test
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 1m55s
Details
DCO action / DCO (pull_request) Successful in 2m51s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 3m24s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 3m19s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m35s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m37s
Details
Tests and linters / Lint (pull_request) Successful in 4m27s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m50s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m22s
Details
Build / Build Components (1.22) (pull_request) Successful in 5m11s
Details
Tests and linters / gopls check (pull_request) Successful in 5m22s
Details
Build / Build Components (1.23) (pull_request) Successful in 5m12s
Details
a6083d0052 
The `TestGCDropsObjectInhumedFromWritecache` test was flaky because an
asynchronous rebuild operation prevented GC from deleting the object. A
test-only shard option `WithDisabledRebuild` has been added to fix this.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed bugfix/1320-shard-rebuild-flaky-test from a6083d0052 to c07b87f604 2024-09-01 21:53:34 +00:00 Compare
acid-ant approved these changes 2024-09-02 06:32:14 +00:00
fyrchik commented 2024-09-02 07:16:30 +00:00
Owner
Copy link

The commit message is painfully non-descriptive, please, at least mention the test name in the commit message.

The commit message is painfully non-descriptive, please, at least mention the test name in the commit message.
a-savchuk force-pushed bugfix/1320-shard-rebuild-flaky-test from c07b87f604 to 4b0d43a6f0 2024-09-02 07:21:20 +00:00 Compare
a-savchuk force-pushed bugfix/1320-shard-rebuild-flaky-test from 4b0d43a6f0 to 2b3fc50681 2024-09-02 07:27:47 +00:00 Compare
a-savchuk changed title from test: Fix flaky test to shard: Fix `TestGCDropsObjectInhumedFromWritecache` flaky test 2024-09-02 07:28:03 +00:00
fyrchik approved these changes 2024-09-02 07:31:09 +00:00
fyrchik merged commit 2b3fc50681 into master 2024-09-02 07:45:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1346
No description provided.
Delete branch "a-savchuk/frostfs-node:bugfix/1320-shard-rebuild-flaky-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?