WIP: node: Add ability to evacuate objects from REP 1
only
#1350
No reviewers
TrueCloudLab/storage-core-developers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1350
Loading…
Reference in a new issue
No description provided.
Delete branch "acid-ant/frostfs-node:feat/evac-skip-rep-one"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Blocked by #1356
Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com
MAINTENANCE
REP 1
only26a007a017
tod64712f25a
d64712f25a
to99441bf077
99441bf077
to0574590325
0574590325
to37ceddedc4
37ceddedc4
toaa6083f90c
aa6083f90c
toa6986dfcf3
WIP: node: Add ability to evacuate objects from `REP 1` onlyto node: Add ability to evacuate objects from `REP 1` only@ -654,3 +656,3 @@
}
addr := toEvacuate[i].Address
if prm.RepOneOnly {
Could you clarify, please, what a problem does this PR solve? Is there a specific case that requires to evacuate only
REP 1
containers? May it be that we'll need to evacuateREP 2
,REP 3
etc. only?Just to do it quicker. It is not a recommended way, but may be helpful in emergency situation, when disk is going to die.
@ -706,0 +720,4 @@
return false, err
}
p := c.Value.PlacementPolicy()
for i := range p.NumberOfReplicas() {
Looks like
REP 1 SELECT 1 FROM X1 REP 1 SELECT 1 FROM X2
will defined as repOne.Right, and I think that condition should be strong and simple. In other case, we need to check if current node should store
REP 1
or not. Should we do that check instead of the currently implemented?I don't know. But I think there is no difference between
REP 1 SELECT 1 FROM X1 REP 1 SELECT 1 FROM X2
andREP 2 SELECT 2 FROM X
policies, as both of then require 2 object instances.a6986dfcf3
toe281d31fbc
node: Add ability to evacuate objects from `REP 1` onlyto WIP: node: Add ability to evacuate objects from `REP 1` onlye281d31fbc
to69c75a660b
69c75a660b
to94e8629888
94e8629888
to763a7cef1c
763a7cef1c
tobcc0fed99c
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.