adm/morph: Add delta flag to 'force-new-epoch' #1380

achuprov · 2024-09-16T14:01:00Z

achuprov commented

2024-09-16 14:01:00 +00:00

 bin/frostfs-adm morph force-new-epoch --config /home/achuprov/Documents/work/frostfs-dev-env/frostfs-adm.yml --delta=100
Current epoch: 326, increase to 426.
Waiting for transactions to persist...

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1372 ``` bin/frostfs-adm morph force-new-epoch --config /home/achuprov/Documents/work/frostfs-dev-env/frostfs-adm.yml --delta=100 Current epoch: 326, increase to 426. Waiting for transactions to persist... ``` Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

achuprov added 1 commit 2024-09-16 14:01:01 +00:00

[#1372 ] adm/morph: Add delta flag to 'force-new-epoch'

DCO action / DCO (pull_request) Successful in 27s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 34s

Details

Pre-commit hooks / Pre-commit (pull_request) Failing after 2m25s

Details

Vulncheck / Vulncheck (pull_request) Successful in 2m34s

Details

Build / Build Components (pull_request) Successful in 2m46s

Details

Tests and linters / Tests with -race (pull_request) Successful in 3m26s

Details

Tests and linters / gopls check (pull_request) Successful in 3m35s

Details

Tests and linters / Staticcheck (pull_request) Successful in 3m43s

Details

Tests and linters / Lint (pull_request) Successful in 3m48s

Details

Tests and linters / Tests (pull_request) Successful in 3m47s

Details

3d06da9073

Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

achuprov force-pushed feat/force-multi-epoch from 3d06da9073 to f628e78b55

2024-09-16 14:01:56 +00:00

Compare

dstepanov-yadro reviewed 2024-09-16 14:37:03 +00:00

cmd/frostfs-adm/internal/modules/morph/helper/netmap.go Outdated

					
				@ -79,3 +79,3 @@

					}

					newEpoch := curr + 1

					newEpoch := curr + countEpoch

dstepanov-yadro commented

2024-09-16 14:37:03 +00:00

What happens if countEpoch is negative?

What happens if `countEpoch` is negative?

achuprov commented

2024-09-18 15:20:50 +00:00

Add additional check at the frostfs-adm level

Add additional check at the `frostfs-adm` level

dstepanov-yadro marked this conversation as resolved

achuprov force-pushed feat/force-multi-epoch from f628e78b55 to 6bcee899b7

2024-09-18 15:15:53 +00:00

Compare

achuprov force-pushed feat/force-multi-epoch from 6bcee899b7 to d4abfe97f3

2024-09-18 15:16:25 +00:00

Compare

achuprov requested review from storage-core-committers 2024-09-18 15:18:51 +00:00

achuprov requested review from storage-core-developers 2024-09-18 15:18:57 +00:00

dstepanov-yadro approved these changes 2024-09-19 09:27:03 +00:00

Dismissed

aarifullin approved these changes 2024-09-20 07:53:35 +00:00

achuprov force-pushed feat/force-multi-epoch from d4abfe97f3 to 2210c08dc3

2024-09-20 08:11:01 +00:00

Compare

achuprov force-pushed feat/force-multi-epoch from 2210c08dc3 to 945b7c740b

2024-09-20 08:42:12 +00:00

Compare

dstepanov-yadro approved these changes 2024-09-20 08:53:31 +00:00

dstepanov-yadro merged commit 945b7c740b into master

2024-09-20 08:53:45 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1380