TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

engine: Fix tests #1381

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/engine_tests_drop_eventually into master 2024-09-23 08:19:56 +00:00
Conversation 0 Commits 1 Files changed 4 +11 -47
dstepanov-yadro commented 2024-09-17 08:30:10 +00:00
Member
Copy link

Drop not required Eventually calls:

  • head and get must return object without any delay caused by writecache
  • delete test has shard.FlushWritecache call, so Eventually call is not required too
Drop not required `Eventually` calls: - `head` and `get` must return object without any delay caused by writecache - `delete` test has `shard.FlushWritecache` call, so `Eventually` call is not required too
dstepanov-yadro added 1 commit 2024-09-17 08:30:11 +00:00
[#9999] engine: Fix tests
Some checks failed
DCO action / DCO (pull_request) Successful in 51s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m9s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m10s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m8s
Details
Build / Build Components (pull_request) Successful in 2m28s
Details
Tests and linters / gopls check (pull_request) Successful in 2m34s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m58s
Details
Tests and linters / Lint (pull_request) Successful in 3m46s
Details
Tests and linters / Tests (pull_request) Successful in 6m11s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m20s
Details
05824d374b 
Drop not required `Eventually` calls.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/engine_tests_drop_eventually from 05824d374b to 9723664250 2024-09-17 08:32:07 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-09-17 08:39:57 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-17 08:39:58 +00:00
dstepanov-yadro force-pushed fix/engine_tests_drop_eventually from 9723664250 to bcee839fd9 2024-09-19 08:45:56 +00:00 Compare
aarifullin approved these changes 2024-09-19 08:57:09 +00:00
dstepanov-yadro force-pushed fix/engine_tests_drop_eventually from bcee839fd9 to 1fdfb9ac60 2024-09-20 13:00:45 +00:00 Compare
dstepanov-yadro force-pushed fix/engine_tests_drop_eventually from 1fdfb9ac60 to 0b87be804a 2024-09-23 08:11:11 +00:00 Compare
dstepanov-yadro merged commit 0b87be804a into master 2024-09-23 08:19:56 +00:00
dstepanov-yadro referenced this pull request from a commit 2024-09-23 08:19:57 +00:00
[#1381] engine: Fix tests
dstepanov-yadro deleted branch fix/engine_tests_drop_eventually 2024-09-23 08:19:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1381
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/engine_tests_drop_eventually"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?