TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 93 Pull requests 4 Projects Releases 1 Activity Actions

putSvc: Fix relay #1394

Merged
acid-ant merged 1 commit from dstepanov-yadro/frostfs-node:fix/put_relay into master 2024-09-25 15:34:18 +00:00
Conversation 0 Commits 1 Files changed 3 +7 -6
dstepanov-yadro commented 2024-09-25 14:27:43 +00:00
Member
Copy link

Put must use relay only with signature: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/support/v0.42/pkg/services/object/put/streamer.go#L80
After #1344 and #1392 put service tries to relay request without signature. Put v2/streamer doesn't save chunks, so relay does nothing.

Put must use relay only with signature: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/support/v0.42/pkg/services/object/put/streamer.go#L80 After https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1344 and https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1392 put service tries to relay request without signature. Put v2/streamer doesn't save chunks, so relay does nothing.
dstepanov-yadro added 1 commit 2024-09-25 14:27:43 +00:00
[#9999] putSvc: Fix relay
All checks were successful
DCO action / DCO (pull_request) Successful in 1m6s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m47s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m25s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m18s
Details
Build / Build Components (pull_request) Successful in 2m38s
Details
Tests and linters / gopls check (pull_request) Successful in 2m51s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m32s
Details
Tests and linters / Lint (pull_request) Successful in 4m10s
Details
Tests and linters / Tests (pull_request) Successful in 6m19s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m22s
Details
c03b4ab19a 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/put_relay from c03b4ab19a to a5e1aa22c9 2024-09-25 14:28:43 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-09-25 14:37:28 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-25 14:37:31 +00:00
aarifullin approved these changes 2024-09-25 14:59:55 +00:00
aarifullin left a comment
Member
Copy link

Thanks for this important fix

Thanks for this important fix
acid-ant approved these changes 2024-09-25 15:34:11 +00:00
acid-ant merged commit a5e1aa22c9 into master 2024-09-25 15:34:18 +00:00
acid-ant referenced this pull request from a commit 2024-09-25 15:34:20 +00:00
[#1394] putSvc: Fix relay
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1394
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/put_relay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?