proxy-add-account should be able to parse --alphabet-wallets from CLI #1400

Closed
opened 2024-09-30 11:12:50 +00:00 by potyarkin · 1 comment
Member

Expected Behavior

frostfs-adm morph proxy-add-account should work correctly when --alphabet-wallets location is provided via CLI.

Current Behavior

frostfs-adm morph proxy-add-account does not support --alphabet-wallets:

Error: unknown flag: --alphabet-wallets

But it does not work without that parameter:

processing error: can't initialize context: can't read alphabet wallets dir: open : no such file or directory

Adding alphabet-wallets to YAML config worked as expected.

Possible Solution

Add --alphabet-wallets flag to this subcommand, similar to many other subcommands in frostfs-adm

Steps to Reproduce (for bugs)

  • frostfs-adm morph proxy-add-account --account $ACCOUNT --rpc-endpoint $ENDPOINT --alphabet-wallets $ALPHABET_DIR
  • Command above should not fail (if valid parameter values are provided)

Context

I was trying to add an account to proxy wallet without creating a YAML config file for frostfs-adm.

Regression

No.

Your Environment

  • Version used: frostfs-adm v0.42.9, also reproduced with current master
  • Server setup and configuration: n/a
  • Operating System and version (uname -a): n/a
## Expected Behavior `frostfs-adm morph proxy-add-account` should work correctly when `--alphabet-wallets` location is provided via CLI. ## Current Behavior `frostfs-adm morph proxy-add-account` does not support `--alphabet-wallets`: ``` Error: unknown flag: --alphabet-wallets ``` But it does not work without that parameter: ``` processing error: can't initialize context: can't read alphabet wallets dir: open : no such file or directory ``` Adding `alphabet-wallets` to YAML config worked as expected. ## Possible Solution Add `--alphabet-wallets` flag to this subcommand, similar to many other subcommands in `frostfs-adm` ## Steps to Reproduce (for bugs) - `frostfs-adm morph proxy-add-account --account $ACCOUNT --rpc-endpoint $ENDPOINT --alphabet-wallets $ALPHABET_DIR` - Command above should not fail (if valid parameter values are provided) ## Context I was trying to add an account to proxy wallet without creating a YAML config file for frostfs-adm. ## Regression No. ## Your Environment * Version used: frostfs-adm v0.42.9, also reproduced with current [master](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/d0ed29b3c73626f6bf881090f86bdc834d81acc1) * Server setup and configuration: n/a * Operating System and version (`uname -a`): n/a
potyarkin added the
bug
frostfs-adm
P3
triage
labels 2024-09-30 11:12:50 +00:00
acid-ant self-assigned this 2024-09-30 11:14:37 +00:00
Owner

Closed via #1401

Closed via #1401
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1400
No description provided.