TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 6 Projects Releases 1 Activity Actions

fix/small-object-parts-locking #141

Merged
fyrchik merged 1 commit from carpawell/frostfs-node:fix/small-object-parts-locking into master 2023-03-27 07:28:33 +00:00
Conversation 1 Commits 1 Files changed 2 +26 -6
carpawell commented 2023-03-15 17:25:03 +00:00
Contributor
Copy link

I decided to implement the first approach (client side pain). Could not find any more error-proof solution. May be discussed.

I decided to implement [the first approach](https://github.com/nspcc-dev/neofs-node/issues/2093#issuecomment-1339608295) (client side pain). Could not find any more error-proof solution. May be discussed.
carpawell added the
frostfs-node
P0
 labels 2023-03-15 17:25:03 +00:00
carpawell self-assigned this 2023-03-15 17:25:03 +00:00
carpawell requested review from storage-core-committers 2023-03-15 17:25:15 +00:00
carpawell requested review from storage-core-developers 2023-03-15 17:25:15 +00:00
carpawell changed title from fix/small-object-parts-locking to WIP: fix/small-object-parts-locking 2023-03-15 17:26:04 +00:00
carpawell force-pushed fix/small-object-parts-locking from 56da6f0dd8 to d491f7befe 2023-03-15 17:29:37 +00:00 Compare
fyrchik removed the
P0
 label 2023-03-17 06:48:14 +00:00
carpawell force-pushed fix/small-object-parts-locking from d491f7befe to f9423f2e6c 2023-03-22 14:37:40 +00:00 Compare
carpawell force-pushed fix/small-object-parts-locking from f9423f2e6c to 55cb427a09 2023-03-22 14:38:16 +00:00 Compare
carpawell commented 2023-03-22 14:39:48 +00:00
Author
Contributor
Copy link

Lets merge that cause it just works. After TrueCloudLab/frostfs-sdk-go#38 is resolved, CLI code can be simplified.

Lets merge that cause it just works. After https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/38 is resolved, CLI code can be simplified.
carpawell changed title from WIP: fix/small-object-parts-locking to fix/small-object-parts-locking 2023-03-22 14:39:50 +00:00
carpawell added the due date 2023-03-24 2023-03-22 16:02:42 +00:00
fyrchik reviewed 2023-03-23 06:14:16 +00:00
cmd/frostfs-cli/modules/object/lock.go Outdated
@ -8,6 +8,7 @@ import (
"time"
objectV2 "git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/object"
internal "git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/client"
fyrchik commented 2023-03-23 06:14:00 +00:00
Owner
Copy link

Isn't it the same package as in the line below?

Isn't it the same package as in the line below?
carpawell commented 2023-03-23 07:48:06 +00:00
Author
Contributor
Copy link

fixed

fixed
carpawell commented 2023-03-23 07:48:11 +00:00
Author
Contributor
Copy link

fixed

fixed
carpawell force-pushed fix/small-object-parts-locking from 55cb427a09 to a626354b1f 2023-03-23 07:48:05 +00:00 Compare
fyrchik approved these changes 2023-03-23 08:27:09 +00:00
cmd/frostfs-cli/modules/object/lock.go
@ -42,3 +47,2 @@
}
key := key.GetOrGenerate(cmd)
if _, ok := oidM[oID]; ok {
fyrchik commented 2023-03-23 08:27:06 +00:00
Owner
Copy link

Seems like a separate feature?

Seems like a separate feature?
carpawell commented 2023-03-23 16:46:39 +00:00
Author
Contributor
Copy link

well, could be considered so. i just imagined some "responsible" user that looks for all the parts of a big object and passes all of them to the object lock cmd. a separate commit for that?

well, could be considered so. i just imagined some "responsible" user that looks for all the parts of a big object and passes all of them to the `object lock` cmd. a separate commit for that?
dstepanov-yadro approved these changes 2023-03-23 08:59:11 +00:00
fyrchik merged commit 3c7ed21f74 into master 2023-03-27 07:28:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
carpawell
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2023-03-24

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#141
No description provided.
Delete branch "carpawell/frostfs-node:fix/small-object-parts-locking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?