TrueCloudLab/frostfs-node

Fork 27

Unify metric handling #1410

New issue

Closed

opened 2024-10-02 11:32:22 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-10-02 11:32:22 +00:00

Owner

In blobstor we have noopMetrics as the default implementation.
In the engine and shard we have != nil comparisons around all methods.

Let's stick with a single approach, to me blobstor one looks better, as it produces 3x less lines of code.

In blobstor we have `noopMetrics` as the default implementation. In the engine and shard we have `!= nil` comparisons around all methods. Let's stick with a single approach, to me blobstor one looks better, as it produces 3x less lines of code.

fyrchik added the

labels 2024-10-02 11:32:42 +00:00

fyrchik added this to the v0.44.0 milestone 2024-10-02 11:32:48 +00:00

fyrchik self-assigned this 2024-10-03 07:39:54 +00:00

fyrchik referenced this issue from a pull request that will close it,

2024-10-03 07:46:50 +00:00

Provide default metrics implementations #1411

dstepanov-yadro referenced this issue from a commit

2024-10-03 08:23:09 +00:00

[#1410] shard: Move MetricsWriter interface to a separate file

dstepanov-yadro referenced this issue from a commit

2024-10-03 08:23:09 +00:00

[#1410] shard: Provide the default implementation for MetricsWriter

dstepanov-yadro referenced this issue from a commit

2024-10-03 08:23:09 +00:00

[#1410] engine: Provide the default implementation to MetricsRegister

dstepanov-yadro closed this issue

2024-10-03 08:23:09 +00:00

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1410

No description provided.