TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

Use specific values in message about address mismatch #1431

Merged
acid-ant merged 1 commit from potyarkin/frostfs-node:feature/better-error-message into master 2024-10-15 08:01:24 +00:00
Conversation 2 Commits 1 Files changed 1 +1 -1
potyarkin commented 2024-10-14 14:39:36 +00:00
Member
Copy link

This makes troubleshooting failed operations much easier:

Before:

status: code = 1024 message = session token is missing but object owner id is different from the default key

After:

status: code = 1024 message = session token is missing but object owner id (NgxTo1Vsi5NUJ9DicGCgoowiH35k6omp1Q) is different from the default key (NejLbQpojKJWec4NQRMBhzsrmCyhXfGJJe)
This makes troubleshooting failed operations much easier: Before: status: code = 1024 message = session token is missing but object owner id is different from the default key After: status: code = 1024 message = session token is missing but object owner id (NgxTo1Vsi5NUJ9DicGCgoowiH35k6omp1Q) is different from the default key (NejLbQpojKJWec4NQRMBhzsrmCyhXfGJJe)
potyarkin added 1 commit 2024-10-14 14:39:37 +00:00
[#1431] Use specific values in message about address mismatch
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 51s
Details
DCO action / DCO (pull_request) Successful in 1m1s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m8s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m4s
Details
Build / Build Components (pull_request) Successful in 2m17s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m36s
Details
Tests and linters / Lint (pull_request) Successful in 3m26s
Details
Tests and linters / Tests (pull_request) Successful in 3m42s
Details
Tests and linters / gopls check (pull_request) Successful in 3m54s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m38s
Details
5239b269c4 
This makes troubleshooting failed operations much easier

Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>
fyrchik approved these changes 2024-10-14 15:16:19 +00:00
fyrchik commented 2024-10-14 15:17:07 +00:00
Owner
Copy link

Please, prefix the commit message with services/object: or objsvc: (look at the history for examples).

Please, prefix the commit message with `services/object:` or `objsvc:` (look at the history for examples).
acid-ant approved these changes 2024-10-15 06:04:27 +00:00
potyarkin force-pushed feature/better-error-message from 5239b269c4 to a7fe9655d3 2024-10-15 07:05:21 +00:00 Compare
potyarkin commented 2024-10-15 07:13:56 +00:00
Author
Member
Copy link

✅ Commit message updated

✅ Commit message updated
potyarkin force-pushed feature/better-error-message from a7fe9655d3 to 714ff784fa 2024-10-15 07:34:05 +00:00 Compare
acid-ant merged commit 714ff784fa into master 2024-10-15 08:01:24 +00:00
potyarkin deleted branch feature/better-error-message 2024-10-15 08:03:06 +00:00
fyrchik referenced this pull request from a commit 2024-10-15 08:54:01 +00:00
[#1431] node: Fix comment format
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1431
No description provided.
Delete branch "potyarkin/frostfs-node:feature/better-error-message"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?