`pkg/morph/client.WithDialSource()` takes internal structure as parameter #1456

New issue

Closed

opened 2024-10-29 13:52:00 +00:00 by alexvanin · 0 comments

alexvanin commented

2024-10-29 13:52:00 +00:00

Owner

pkg/morph/client package contains public Client instance which supports multiple RPC endpoints and connection switch. It is very convenient to import this client to multiplex connection to blockchain.

#1422 introduces multinet support and adds new WithDialSource option. However it takes internal-defined structure as parameter, so it is not possible to use outside of frostfs-node repository.

Is it possible to use public interface instead of internal package implementation?

`pkg/morph/client` package contains public `Client` instance which supports multiple RPC endpoints and connection switch. It is very convenient to import this client to multiplex connection to blockchain. #1422 introduces multinet support and adds new `WithDialSource` option. However it takes internal-defined structure as parameter, so it is not possible to use outside of frostfs-node repository. Is it possible to use public interface instead of internal package implementation?

alexvanin added the

triage

label 2024-10-29 13:52:00 +00:00

fyrchik added the

enhancement

frostfs-node

labels 2024-10-29 13:55:12 +00:00

fyrchik added this to the v0.44.0 milestone 2024-10-29 13:55:14 +00:00

dstepanov-yadro was assigned by fyrchik

2024-10-29 13:55:18 +00:00

fyrchik changed title from ~~pkg/morph/client.WithDialSource() takes internal structure as parameter~~ to pkg/morph/client.WithDialSource() takes internal structure as parameter

2024-10-29 13:55:37 +00:00

fyrchik removed the

triage

label 2024-10-29 13:55:44 +00:00

dstepanov-yadro referenced this issue from a pull request that will close it,

2024-10-29 14:18:14 +00:00

morph: Use DialerSource interface instead of internal struct #1457

dstepanov-yadro closed this issue

2024-10-29 15:19:24 +00:00

dstepanov-yadro referenced this issue from a commit

2024-10-29 15:19:24 +00:00

[#1456] morph: Use DialerSource interface instead of internal struct