TrueCloudLab/frostfs-node

cli: Do not read config for --version and --help #1460

New issue

Open

opened 2024-10-30 11:54:56 +00:00 by fyrchik · 2 comments

fyrchik commented

2024-10-30 11:54:56 +00:00

Owner

Currently, we do in the initializer, which is executed for every command.
Let's see if it is possible to avoid.

Currently, we do in the initializer, which is executed for every command. Let's see if it is possible to avoid.

fyrchik added the

labels 2024-10-30 11:54:56 +00:00

fyrchik added this to the vNext milestone 2024-10-30 11:55:27 +00:00

fyrchik added the

good first issue

labels 2024-10-30 12:18:15 +00:00

fyrchik added the

label 2024-11-06 07:45:08 +00:00

fyrchik commented

2024-11-06 07:46:02 +00:00

Author

Owner

It seems we can handle config reading the same way we handle tracing, via PersistentPreRun function.
It is almost the same, as for tracing we check --tracing flag, and here we need to check --help and --version.

It seems we can handle config reading the same way we handle tracing, via `PersistentPreRun` function. It is almost the same, as for tracing we check `--tracing` flag, and here we need to check `--help` and `--version`.

a-savchuk commented

2024-11-06 08:32:38 +00:00

Member

It seems we can handle config reading the same way we handle tracing, via PersistentPreRun function.
It is almost the same, as for tracing we check --tracing flag, and here we need to check --help and --version.

I like it

> It seems we can handle config reading the same way we handle tracing, via `PersistentPreRun` function. > It is almost the same, as for tracing we check `--tracing` flag, and here we need to check `--help` and `--version`. I like it

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1460

No description provided.