Check that `go mod tidy` executing does not result in file changes #1461

New issue

Closed

opened 2024-10-30 12:40:22 +00:00 by dstepanov-yadro · 4 comments

dstepanov-yadro commented

2024-10-30 12:40:22 +00:00

Member

Checkout v0.38.9 tag, run make all, go.sum will have changes.

Describe the solution you'd like

Add Makefile and CI/CD check that go mod tidy executing does not result in file changes

## Is your feature request related to a problem? Please describe. Checkout `v0.38.9` tag, run `make all`, `go.sum` will have changes. ## Describe the solution you'd like Add Makefile and CI/CD check that `go mod tidy` executing does not result in file changes

👍 1

dstepanov-yadro added the

labels 2024-10-30 12:40:22 +00:00

fyrchik commented

2024-10-30 15:22:57 +00:00

Owner

We have go-mod-tidy in pre-commit.
And we execute pre-commit in .forgejo/workflows/pre-commit.yml.

Is that what you want? #1118

We have `go-mod-tidy` in `pre-commit`. And we execute pre-commit in `.forgejo/workflows/pre-commit.yml`. Is that what you want? #1118

dstepanov-yadro commented

2024-10-30 15:26:38 +00:00

Author

Member

We have go-mod-tidy in pre-commit.
And we execute pre-commit in .forgejo/workflows/pre-commit.yml.

Is that what you want? #1118

As I see tag v0.38.9 has this check. Does it work correctly?

> We have `go-mod-tidy` in `pre-commit`. > And we execute pre-commit in `.forgejo/workflows/pre-commit.yml`. > > Is that what you want? #1118 As I see tag `v0.38.9` has this check. Does it work correctly?

fyrchik commented

2024-10-31 06:18:03 +00:00

Owner

I don't see it at v0.38.9 https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/v0.38.9/.forgejo/workflows

I don't see it at `v0.38.9` https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/v0.38.9/.forgejo/workflows

dstepanov-yadro commented

2024-10-31 07:03:25 +00:00

Author

Member

I checked https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/v0.38.9/.woodpecker/pre-commit.yml
But looks like this file is unused now. Then looks like this is already done, so close issue.

I checked https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/v0.38.9/.woodpecker/pre-commit.yml But looks like this file is unused now. Then looks like this is already done, so close issue.

dstepanov-yadro closed this issue

2024-10-31 07:03:27 +00:00