TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

policer: Add tracing span #1473

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:feat/policer_tracing into master 2024-11-06 08:15:12 +00:00
Conversation 0 Commits 1 Files changed 1 +11
dstepanov-yadro commented 2024-11-06 07:58:23 +00:00
Member
Copy link

To filter HEAD requests from policer.

To filter HEAD requests from policer.
dstepanov-yadro added 1 commit 2024-11-06 07:58:24 +00:00
[#9999] policer: Add tracing span
All checks were successful
DCO action / DCO (pull_request) Successful in 2m25s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m30s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m21s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m9s
Details
Build / Build Components (pull_request) Successful in 3m28s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m37s
Details
Tests and linters / Lint (pull_request) Successful in 4m19s
Details
Tests and linters / gopls check (pull_request) Successful in 4m41s
Details
Tests and linters / Tests (pull_request) Successful in 7m17s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m19s
Details
1a567511f8 
To filter HEAD requests of policer.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/policer_tracing from 1a567511f8 to 64e8e70f8d 2024-11-06 07:59:17 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-11-06 07:59:31 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-11-06 07:59:36 +00:00
fyrchik reviewed 2024-11-06 08:02:55 +00:00
pkg/services/policer/check.go Outdated
@ -17,3 +20,4 @@
)
func (p *Policer) processObject(ctx context.Context, objInfo objectcore.Info) error {
ctx, span := tracing.StartSpanFromContext(ctx, "Policer.ProcessObject", trace.WithAttributes(
fyrchik commented 2024-11-06 08:02:52 +00:00
Owner
Copy link

Do we have any spans in replicator? It should also be useful.

Do we have any spans in replicator? It should also be useful.
dstepanov-yadro commented 2024-11-06 08:06:30 +00:00
Author
Member
Copy link

Yes, we do:

Line 35 in 17ec841
ctx, span := tracing.StartSpanFromContext(ctx, "Replicator.HandleReplicateTask",

Yes, we do: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/17ec84151b4f9f3d2ff593ecdad41b8c0c860e02/pkg/services/replicator/process.go#L35
pkg/services/policer/check.go Outdated
@ -20,0 +23,4 @@
ctx, span := tracing.StartSpanFromContext(ctx, "Policer.ProcessObject", trace.WithAttributes(
attribute.String("address", objInfo.Address.String()),
attribute.Bool("is_linking_object", objInfo.IsLinkingObject),
attribute.Bool("is_EC_part", objInfo.ECInfo != nil),
fyrchik commented 2024-11-06 08:02:19 +00:00
Owner
Copy link

https://opentelemetry.io/docs/specs/semconv/general/attribute-naming/

Names SHOULD be lowercase.

https://opentelemetry.io/docs/specs/semconv/general/attribute-naming/ >Names SHOULD be lowercase.
dstepanov-yadro commented 2024-11-06 08:05:59 +00:00
Author
Member
Copy link

fixed

fixed
dstepanov-yadro force-pushed feat/policer_tracing from 64e8e70f8d to 69b6b2b321 2024-11-06 08:05:55 +00:00 Compare
fyrchik approved these changes 2024-11-06 08:14:51 +00:00
a-savchuk approved these changes 2024-11-06 08:15:00 +00:00
dstepanov-yadro merged commit 33ad753302 into master 2024-11-06 08:15:12 +00:00
dstepanov-yadro deleted branch feat/policer_tracing 2024-11-06 08:15:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
a-savchuk
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1473
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/policer_tracing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?