TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

Bump sdk-go version and fix dependencies #1479

Merged
fyrchik merged 3 commits from aarifullin/frostfs-node:fix/bump_sdk_go into master 2024-11-20 15:43:53 +00:00
Conversation 1 Commits 3 Files changed 163 +251 -252
aarifullin commented 2024-11-07 14:53:32 +00:00
Member
Copy link
  • Update version within go.mod;
  • Fix deprecated frostfs-api-go/v2 package and use frostfs-sdk-go/api instead.
  • control: Regenerate protobufs for service
  • tree: Regenerate service protobufs
* Update version within go.mod; * Fix deprecated frostfs-api-go/v2 package and use frostfs-sdk-go/api instead. * control: Regenerate protobufs for service * tree: Regenerate service protobufs
aarifullin added the
refactoring
 label 2024-11-07 14:53:32 +00:00
aarifullin added 3 commits 2024-11-07 14:53:33 +00:00 
* Update version within go.mod;
* Fix deprecated frostfs-api-go/v2 package and use frostfs-sdk-go/api
  instead.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
[#XX] tree: Regenerate service protobufs
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m27s
Details
DCO action / DCO (pull_request) Failing after 2m38s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m57s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m9s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m27s
Details
Tests and linters / Lint (pull_request) Successful in 4m11s
Details
Build / Build Components (pull_request) Successful in 4m45s
Details
Tests and linters / gopls check (pull_request) Successful in 4m59s
Details
Tests and linters / Tests (pull_request) Successful in 8m31s
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m0s
Details
9077f303cb 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2024-11-07 14:53:43 +00:00
aarifullin requested review from storage-core-developers 2024-11-07 14:53:45 +00:00
aarifullin force-pushed fix/bump_sdk_go from 9077f303cb to 44404d2231 2024-11-07 14:54:33 +00:00 Compare
aarifullin changed title from Bump sdk-go version and fix dependencies to WIP: Bump sdk-go version and fix dependencies 2024-11-07 14:54:51 +00:00
aarifullin force-pushed fix/bump_sdk_go from 44404d2231 to 0d46afa3c2 2024-11-07 14:59:24 +00:00 Compare
aarifullin changed title from WIP: Bump sdk-go version and fix dependencies to Bump sdk-go version and fix dependencies 2024-11-07 15:00:31 +00:00
fyrchik reviewed 2024-11-08 06:41:25 +00:00
fyrchik left a comment
Owner
Copy link

Please, tell me you rewrote imports automatically (with sed), so that I can skip the review step :)

Please, tell me you rewrote imports automatically (with sed), so that I can skip the review step :)
Makefile Outdated
@ -12,3 +12,3 @@
TRUECLOUDLAB_LINT_VERSION ?= 0.0.7
PROTOC_VERSION ?= 25.0
PROTOGEN_FROSTFS_VERSION ?= $(shell go list -f '{{.Version}}' -m git.frostfs.info/TrueCloudLab/frostfs-api-go/v2)
PROTOGEN_FROSTFS_VERSION ?= $(shell go list -f '{{.Version}}' -m git.frostfs.info/TrueCloudLab/frostfs-sdk-go@master)
fyrchik commented 2024-11-08 06:40:32 +00:00
Owner
Copy link

Earlier we didn't have version suffix, why have you added it?

Earlier we didn't have version suffix, why have you added it?
aarifullin commented 2024-11-08 07:45:24 +00:00
Author
Member
Copy link

Right, @master is just a leftover after some experiments. I've removed it out

Right, `@master` is just a leftover after some experiments. I've removed it out
aarifullin force-pushed fix/bump_sdk_go from 0d46afa3c2 to 764450d04a 2024-11-08 07:43:58 +00:00 Compare
aarifullin commented 2024-11-08 07:48:07 +00:00
Author
Member
Copy link

Please, tell me you rewrote imports automatically (with sed), so that I can skip the review step :)

Yes, I did it automatically. You don't need to check it.
The only part I'd like to ask you to look over: regenerated tree and control service protobufs as some lines added for marshalers - I believe the plugin made everything correct

> Please, tell me you rewrote imports automatically (with sed), so that I can skip the review step :) Yes, I did it automatically. You don't need to check it. The only part I'd like to ask you to look over: regenerated `tree` and `control` service protobufs as some lines added for marshalers - I believe the plugin made everything correct
fyrchik added the
internal
 label 2024-11-08 08:53:38 +00:00
fyrchik added this to the v0.44.0 milestone 2024-11-08 08:53:41 +00:00
dstepanov-yadro approved these changes 2024-11-08 10:34:08 +00:00
fyrchik merged commit 764450d04a into master 2024-11-08 12:00:49 +00:00
acid-ant approved these changes 2024-11-08 12:35:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.44.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1479
No description provided.
Delete branch "aarifullin/frostfs-node:fix/bump_sdk_go"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?