Remove yet more eACL leftovers #1483

fyrchik · 2024-11-11T06:43:00Z

fyrchik commented

2024-11-11 06:43:00 +00:00

No description provided.

fyrchik added 4 commits 2024-11-11 06:43:00 +00:00

node: Remove eACL cache 5b1b3ab2a9

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

morph: Remove container.GetEACL() 1c982bbfd6

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

cli/docs: Remove set-eacl mention 29d0ff3770

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

cli: Deprecate --basic-acl flag

Tests and linters / Run gofumpt (pull_request) Successful in 58s

Details

DCO action / DCO (pull_request) Failing after 1m18s

Details

Vulncheck / Vulncheck (pull_request) Successful in 2m17s

Details

Build / Build Components (pull_request) Successful in 2m32s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 3m5s

Details

Tests and linters / Staticcheck (pull_request) Successful in 3m8s

Details

Tests and linters / Lint (pull_request) Successful in 4m20s

Details

Tests and linters / gopls check (pull_request) Successful in 4m23s

Details

Tests and linters / Tests with -race (pull_request) Successful in 5m21s

Details

Tests and linters / Tests (pull_request) Successful in 6m17s

Details

c362ea02c9

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-11-11 06:43:12 +00:00

fyrchik requested review from storage-core-developers 2024-11-11 06:43:17 +00:00

fyrchik force-pushed remove-eacl from c362ea02c9 to adeebdeba2

2024-11-11 06:45:27 +00:00

Compare

fyrchik force-pushed remove-eacl from adeebdeba2 to 3f801ca593

2024-11-11 06:45:49 +00:00

Compare

acid-ant approved these changes 2024-11-11 06:54:59 +00:00

Dismissed

aarifullin reviewed 2024-11-11 08:45:48 +00:00

cmd/frostfs-cli/modules/container/create.go Outdated

					
				@ -167,6 +167,8 @@ func initContainerCreateCmd() {

					flags.StringVar(&containerACL, "basic-acl", acl.NamePrivate, fmt.Sprintf("HEX encoded basic ACL value or keywords like '%s', '%s', '%s'",

						acl.NamePublicRW, acl.NamePrivate, acl.NamePublicROExtended,

					))

					_ = flags.MarkDeprecated("basic-acl", "it will be removed in the next version of frostfs-cli.") // No error, flag exists.

aarifullin commented

2024-11-11 08:45:48 +00:00

It's OK that this flag is deprecated. Although basic ACL has got not longer effect, a container is still created with acl.NamePrivate - container dump will shot it

Let's remove this:

var basicACL acl.Basic
commonCmd.ExitOnErr(cmd, "decode basic ACL string: %w", basicACL.DecodeString(containerACL))
/* ... */
cnr.SetBasicACL(basicACL)

or make

const zeroBasicACL = 0x0
flags.StringVar(&containerACL, "basic-acl", zeroBasicACL, fmt.Sprintf("HEX encoded basic ACL value or keywords like '%s', '%s', '%s'", acl.NamePublicRW, acl.NamePrivate, acl.NamePublicROExtended))

It's OK that this flag is deprecated. Although basic ACL has got not longer effect, a container is still created with `acl.NamePrivate` - container dump will shot it Let's remove this: ```go var basicACL acl.Basic commonCmd.ExitOnErr(cmd, "decode basic ACL string: %w", basicACL.DecodeString(containerACL)) /* ... */ cnr.SetBasicACL(basicACL) ``` or make ```go const zeroBasicACL = 0x0 flags.StringVar(&containerACL, "basic-acl", zeroBasicACL, fmt.Sprintf("HEX encoded basic ACL value or keywords like '%s', '%s', '%s'", acl.NamePublicRW, acl.NamePrivate, acl.NamePublicROExtended)) ```

fyrchik commented

2024-11-11 12:44:45 +00:00

Removed the flag instead.

aarifullin marked this conversation as resolved

fyrchik force-pushed remove-eacl from 3f801ca593 to 26ed209fcf

2024-11-11 12:44:41 +00:00

Compare

fyrchik dismissed acid-ant's review 2024-11-11 12:44:41 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aarifullin approved these changes 2024-11-11 14:20:30 +00:00

aarifullin left a comment