Improve terminal control key handling #1485

achuprov · 2024-11-11T14:00:24Z

achuprov commented

2024-11-11 14:00:24 +00:00

Close #1396
Added support for left/right arrows, protection against accidental Ctrl+C press.

Close #1396 Added support for `left`/`right` arrows, protection against accidental `Ctrl+C` press.

achuprov force-pushed fix/policyPlaygroun from 488f38ce4e to ed31ac98dc

2024-11-11 14:04:31 +00:00

Compare

acid-ant approved these changes 2024-11-11 17:58:50 +00:00

Dismissed

dstepanov-yadro approved these changes 2024-11-12 06:51:29 +00:00

Dismissed

achuprov force-pushed fix/policyPlaygroun from ed31ac98dc to fbc4d8e221

2024-11-12 07:35:28 +00:00

Compare

aarifullin approved these changes 2024-11-12 07:38:11 +00:00

Dismissed

aarifullin left a comment

Oh, nice!

a-savchuk reviewed 2024-11-12 07:51:40 +00:00

cmd/frostfs-cli/modules/container/policy_playground.go Outdated

					
				@ -198,2 +221,4 @@

								exit = true

								continue

							}

							return fmt.Errorf("reading line: %v", err)

a-savchuk commented

2024-11-12 07:51:40 +00:00

fmt.Errorf("reading line: %w", err). Could we add this to the commit with refactoring?

`fmt.Errorf("reading line: %w", err)`. Could we add this to the commit with refactoring?

a-savchuk marked this conversation as resolved

achuprov force-pushed fix/policyPlaygroun from fbc4d8e221 to 80f8a8fd3a

2024-11-12 08:09:48 +00:00

Compare

achuprov dismissed acid-ant's review 2024-11-12 08:09:49 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed dstepanov-yadro's review 2024-11-12 08:09:49 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed aarifullin's review 2024-11-12 08:09:49 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-11-12 08:19:21 +00:00

a-savchuk approved these changes 2024-11-12 08:40:03 +00:00

acid-ant merged commit 80f8a8fd3a into master

2024-11-12 08:41:39 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

5 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1485