TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

node: Introduce dual service support #1486

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:feat/dual_service_support into master 2024-11-12 08:43:48 +00:00
Conversation 0 Commits 1 Files changed 6 +38
aarifullin commented 2024-11-11 16:02:46 +00:00
Member
Copy link
  • Register GRPC services for both neo.fs.v2 and frost.fs namespaces
  • Use this temporary solution until all nodes are updated
* Register GRPC services for both neo.fs.v2 and frost.fs namespaces * Use this temporary solution until all nodes are updated
aarifullin added the
frostfs-node
internal
 labels 2024-11-11 16:02:46 +00:00
aarifullin added 1 commit 2024-11-11 16:02:46 +00:00
[#XX] node: Introduce dual service support
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 43s
Details
DCO action / DCO (pull_request) Failing after 54s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m59s
Details
Build / Build Components (pull_request) Successful in 3m48s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m10s
Details
Tests and linters / gopls check (pull_request) Successful in 4m15s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m20s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m37s
Details
Tests and linters / Lint (pull_request) Successful in 5m49s
Details
Tests and linters / Tests (pull_request) Successful in 6m46s
Details
e5b527df6f 
* Register GRPC services for both neo.fs.v2 and frost.fs namespaces
* Use this temporary solution until all nodes are updated

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed feat/dual_service_support from e5b527df6f to 03233e994d 2024-11-11 16:03:44 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-11-11 16:04:07 +00:00
aarifullin requested review from storage-core-developers 2024-11-11 16:04:13 +00:00
acid-ant approved these changes 2024-11-11 17:49:41 +00:00
Dismissed
cmd/frostfs-node/accounting.go Outdated
@ -31,2 +32,4 @@
c.cfgGRPC.performAndSave(func(_ string, _ net.Listener, s *grpc.Server) {
accountingGRPC.RegisterAccountingServiceServer(s, server)
// TODO(@aarifullin): remove the dual service registering as soon as migration is complete.
acid-ant commented 2024-11-11 17:46:12 +00:00
Member
Copy link

Maybe it is better to add a link to an issue here?

Maybe it is better to add a link to an issue here?
aarifullin commented 2024-11-12 07:51:25 +00:00
Author
Member
Copy link

I created an issue and mentioned it in the comments

I created an issue and mentioned it in the comments
dstepanov-yadro approved these changes 2024-11-12 06:21:15 +00:00
Dismissed
aarifullin force-pushed feat/dual_service_support from 03233e994d to 546332b471 2024-11-12 07:48:49 +00:00 Compare
aarifullin dismissed acid-ant's review 2024-11-12 07:48:49 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aarifullin dismissed dstepanov-yadro's review 2024-11-12 07:48:49 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-11-12 07:49:37 +00:00
fyrchik merged commit b543569c3f into master 2024-11-12 08:43:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1486
No description provided.
Delete branch "aarifullin/frostfs-node:feat/dual_service_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?