TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

adm: Add command morph netmap-candidates #15

Merged
acid-ant merged 3 commits from feature/1889-morph-nm-candidates into master 2023-02-06 14:26:35 +00:00
Conversation 0 Commits 3 Files changed 69 +332 -255
acid-ant commented 2023-01-13 09:00:34 +00:00 (Migrated from github.com)
Copy link

Close #1889

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #1889 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
alexvanin (Migrated from github.com) reviewed 2023-01-13 09:00:34 +00:00
carpawell (Migrated from github.com) reviewed 2023-01-13 15:59:59 +00:00
cmd/frostfs-adm/internal/modules/morph/netmap_candidates.go
carpawell (Migrated from github.com) commented 2023-01-13 15:49:58 +00:00
Copy link

lets try not to use RunE according to #623?

lets try not to use `RunE` according to #623?
carpawell (Migrated from github.com) commented 2023-01-13 15:51:07 +00:00
Copy link

why do we need it?

why do we need it?
carpawell (Migrated from github.com) commented 2023-01-13 15:56:21 +00:00
Copy link

that context is usually used for complex transactions. for RO purposes it looks too heavy, see morph dump-config as an example

that context is usually used for complex transactions. for RO purposes it looks too heavy, see `morph dump-config` as an example
cmd/frostfs-adm/internal/modules/morph/root.go
carpawell (Migrated from github.com) commented 2023-01-13 15:57:29 +00:00
Copy link

why have you decided to init flags in a separate init and not like it is already done here?

why have you decided to init flags in a separate `init` and not like it is already done here?
pkg/core/netmap/prettyprint.go
carpawell (Migrated from github.com) commented 2023-01-13 15:59:56 +00:00
Copy link

could you, please, make that move in a separate commit?

could you, please, make that move in a separate commit?
acid-ant (Migrated from github.com) reviewed 2023-01-16 06:57:02 +00:00
pkg/core/netmap/prettyprint.go
acid-ant (Migrated from github.com) commented 2023-01-16 06:57:01 +00:00
Copy link

In this case I need to add in adm dependency on cli or duplicate code. Is It ok?

In this case I need to add in `adm` dependency on `cli` or duplicate code. Is It ok?
acid-ant (Migrated from github.com) reviewed 2023-01-16 07:03:19 +00:00
cmd/frostfs-adm/internal/modules/morph/root.go
acid-ant (Migrated from github.com) commented 2023-01-16 07:03:19 +00:00
Copy link

The idea was to reduce amount of lines here, also we are using the same approach in cli.

The idea was to reduce amount of lines here, also we are using the same approach in `cli`.
acid-ant (Migrated from github.com) reviewed 2023-01-16 11:09:59 +00:00
cmd/frostfs-adm/internal/modules/morph/netmap_candidates.go
acid-ant (Migrated from github.com) commented 2023-01-16 11:09:58 +00:00
Copy link

Refactored.

Refactored.
acid-ant (Migrated from github.com) reviewed 2023-01-16 11:10:13 +00:00
cmd/frostfs-adm/internal/modules/morph/netmap_candidates.go
acid-ant (Migrated from github.com) commented 2023-01-16 11:10:13 +00:00
Copy link

Removed.

Removed.
acid-ant (Migrated from github.com) reviewed 2023-01-16 11:10:24 +00:00
cmd/frostfs-adm/internal/modules/morph/netmap_candidates.go
acid-ant (Migrated from github.com) commented 2023-01-16 11:10:24 +00:00
Copy link

Refactored.

Refactored.
acid-ant (Migrated from github.com) reviewed 2023-01-16 11:10:43 +00:00
pkg/core/netmap/prettyprint.go
acid-ant (Migrated from github.com) commented 2023-01-16 11:10:43 +00:00
Copy link

Updated.

Updated.
fyrchik (Migrated from github.com) reviewed 2023-01-23 08:57:36 +00:00
cmd/frostfs-adm/internal/modules/morph/netmap_candidates.go
fyrchik (Migrated from github.com) commented 2023-01-23 08:56:32 +00:00
Copy link

Is it possible to have res == nil and err == nil at the same time?

Is it possible to have `res == nil` and `err == nil` at the same time?
cmd/frostfs-adm/internal/modules/morph/root.go
@ -323,4 +333,7 @@ func init() {
depositNotaryCmd.Flags().String(walletAccountFlag, "", "Wallet account address")
depositNotaryCmd.Flags().String(refillGasAmountFlag, "", "Amount of GAS to deposit")
fyrchik (Migrated from github.com) commented 2023-01-23 08:57:31 +00:00
Copy link

Why not short by default and --verbose for everything?

Why not short by default and `--verbose` for everything?
pkg/core/netmap/prettyprint.go
fyrchik (Migrated from github.com) commented 2023-01-23 07:01:44 +00:00
Copy link

We do not want to have pkg/core/netmap or (any other pkg to depend on cmd package).
Can we use cmd/internal/common instead? Other ideas? @carpawell

We do not want to have `pkg/core/netmap` or (any other `pkg` to depend on `cmd` package). Can we use `cmd/internal/common` instead? Other ideas? @carpawell
acid-ant (Migrated from github.com) reviewed 2023-01-23 09:38:59 +00:00
cmd/frostfs-adm/internal/modules/morph/netmap_candidates.go
acid-ant (Migrated from github.com) commented 2023-01-23 09:38:59 +00:00
Copy link

Removed redundant check.

Removed redundant check.
acid-ant (Migrated from github.com) reviewed 2023-01-23 09:39:23 +00:00
cmd/frostfs-adm/internal/modules/morph/root.go
@ -323,4 +333,7 @@ func init() {
depositNotaryCmd.Flags().String(walletAccountFlag, "", "Wallet account address")
depositNotaryCmd.Flags().String(refillGasAmountFlag, "", "Amount of GAS to deposit")
acid-ant (Migrated from github.com) commented 2023-01-23 09:39:23 +00:00
Copy link

Good idea, replaced with --verbose.

Good idea, replaced with `--verbose`.
acid-ant (Migrated from github.com) reviewed 2023-01-26 08:55:21 +00:00
pkg/core/netmap/prettyprint.go
acid-ant (Migrated from github.com) commented 2023-01-26 08:55:21 +00:00
Copy link

Moved from pkg to cmd/internal/common

Moved from `pkg` to `cmd/internal/common`
fyrchik (Migrated from github.com) reviewed 2023-01-31 08:29:10 +00:00
cmd/frostfs-adm/internal/modules/root.go
fyrchik (Migrated from github.com) commented 2023-01-31 08:28:58 +00:00
Copy link

Can we factor out common flags in a separate commit? And add netmap-candidates in the next one.

Can we factor out common flags in a separate commit? And add `netmap-candidates` in the next one.
cmd/frostfs-cli/internal/client/sdk.go
@ -10,6 +10,7 @@ import (
"github.com/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/common"
"github.com/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
commonCmd "github.com/TrueCloudLab/frostfs-node/cmd/internal/common"
fyrchik (Migrated from github.com) commented 2023-01-31 08:27:49 +00:00
Copy link

There is a typo in the commit message.

There is a typo in the commit message.
acid-ant (Migrated from github.com) reviewed 2023-01-31 10:34:56 +00:00
cmd/frostfs-adm/internal/modules/root.go
acid-ant (Migrated from github.com) commented 2023-01-31 10:34:55 +00:00
Copy link

Done.

Done.
acid-ant (Migrated from github.com) reviewed 2023-01-31 10:35:05 +00:00
cmd/frostfs-cli/internal/client/sdk.go
@ -10,6 +10,7 @@ import (
"github.com/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/common"
"github.com/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/commonflags"
commonCmd "github.com/TrueCloudLab/frostfs-node/cmd/internal/common"
acid-ant (Migrated from github.com) commented 2023-01-31 10:35:04 +00:00
Copy link

Thanks, fixed.

Thanks, fixed.
carpawell (Migrated from github.com) approved these changes 2023-01-31 12:55:41 +00:00
fyrchik (Migrated from github.com) approved these changes 2023-02-06 14:17:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
carpawell
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#15
No description provided.
Delete branch "feature/1889-morph-nm-candidates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?