TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

timer: Remove unused OnDelta() method #1507

Merged
fyrchik merged 3 commits from fyrchik/frostfs-node:remove-unused into master 2024-11-20 08:36:26 +00:00
Conversation 0 Commits 3 Files changed 2 +52 -200
fyrchik commented 2024-11-20 07:46:01 +00:00
Owner
Copy link

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2024-11-20 07:46:02 +00:00
timer: Remove unused OnDelta() method
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m19s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m19s
Details
DCO action / DCO (pull_request) Failing after 2m31s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m51s
Details
Tests and linters / gopls check (pull_request) Successful in 3m28s
Details
Build / Build Components (pull_request) Successful in 3m31s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m42s
Details
Tests and linters / Lint (pull_request) Successful in 4m34s
Details
Tests and linters / Tests (pull_request) Successful in 6m52s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m55s
Details
006401fc3e 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed remove-unused from 006401fc3e to 2f5d845f7b 2024-11-20 07:47:21 +00:00 Compare
fyrchik added 2 commits 2024-11-20 07:56:02 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
timer/test: Use const for constants
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m18s
Details
DCO action / DCO (pull_request) Failing after 2m34s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m51s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m2s
Details
Tests and linters / gopls check (pull_request) Successful in 4m6s
Details
Build / Build Components (pull_request) Successful in 4m55s
Details
Tests and linters / Lint (pull_request) Successful in 5m4s
Details
Vulncheck / Vulncheck (pull_request) Successful in 5m2s
Details
Tests and linters / Tests (pull_request) Successful in 7m10s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m12s
Details
35941babb8 
Make it easy to see what the test is about.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed remove-unused from 35941babb8 to a8f6454e2c 2024-11-20 07:56:07 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-11-20 07:56:07 +00:00
fyrchik requested review from storage-core-developers 2024-11-20 07:56:11 +00:00
fyrchik added this to the v0.44.0 milestone 2024-11-20 07:58:50 +00:00
acid-ant approved these changes 2024-11-20 08:01:42 +00:00
dstepanov-yadro approved these changes 2024-11-20 08:26:37 +00:00
fyrchik merged commit 49a4e727fd into master 2024-11-20 08:36:26 +00:00
fyrchik deleted branch remove-unused 2024-11-20 08:36:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.44.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1507
No description provided.
Delete branch "fyrchik/frostfs-node:remove-unused"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?