TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

adm: Do not use actor for readonly commands #1514

Merged
fyrchik merged 6 commits from fyrchik/frostfs-node:only-read-only into master 2024-11-21 14:37:35 +00:00
Conversation 0 Commits 6 Files changed 11 +47 -61
fyrchik commented 2024-11-21 07:47:05 +00:00
Owner
Copy link

Testing done:
Manually checked that every affected command executes with no errors on dev-env when alphabet-wallets is not provided.

frostfsid: list-namespaces, list-subjects, list-groups, list-group-subjects
nns: get-records, tokens
netmap: netmap-candidates
Testing done: Manually checked that every affected command executes with no errors on dev-env when alphabet-wallets is not provided. ``` frostfsid: list-namespaces, list-subjects, list-groups, list-group-subjects nns: get-records, tokens netmap: netmap-candidates ```
fyrchik added 3 commits 2024-11-21 07:47:06 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
It was not possible previously, because GetAllRecords() was not declared
safe in frostfs-contract.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
[#1514] adm/nns: Do not create actor for readonly commands
All checks were successful
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m1s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m12s
Details
DCO action / DCO (pull_request) Successful in 4m26s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m44s
Details
Build / Build Components (pull_request) Successful in 5m57s
Details
Vulncheck / Vulncheck (pull_request) Successful in 6m39s
Details
Tests and linters / Lint (pull_request) Successful in 7m0s
Details
Tests and linters / gopls check (pull_request) Successful in 7m50s
Details
Tests and linters / Tests (pull_request) Successful in 10m21s
Details
Tests and linters / Tests with -race (pull_request) Successful in 10m18s
Details
2f56a626e9 
`nns get-records` and `nns tokens` command do not need to sign anything,
so remove useless actor and use invoker directly.
`NewLocalActor()` is only used in `ape` and `nns` packages. `ape`
package seem to use it correctly, only when alphabet wallets are
provided, so no changes there.
Also, remove --alphabet-wallets flag from commands that do not need it.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-11-21 07:47:37 +00:00
fyrchik requested review from storage-core-developers 2024-11-21 07:47:42 +00:00
fyrchik force-pushed only-read-only from 2f56a626e9 to 0be126c2cf 2024-11-21 07:47:49 +00:00 Compare
fyrchik changed title from only-read-only to adm: Do not use actor for readonly commands 2024-11-21 07:47:49 +00:00
fyrchik force-pushed only-read-only from 0be126c2cf to a2e1b2cf43 2024-11-21 07:52:37 +00:00 Compare
fyrchik force-pushed only-read-only from a2e1b2cf43 to ecc77381f9 2024-11-21 07:53:09 +00:00 Compare
fyrchik force-pushed only-read-only from ecc77381f9 to 8e3a2eaed9 2024-11-21 07:54:48 +00:00 Compare
fyrchik force-pushed only-read-only from 8e3a2eaed9 to bd8459312a 2024-11-21 08:53:30 +00:00 Compare
acid-ant approved these changes 2024-11-21 12:22:14 +00:00
aarifullin approved these changes 2024-11-21 13:27:44 +00:00
fyrchik merged commit 99f9e59de9 into master 2024-11-21 14:37:35 +00:00
fyrchik deleted branch only-read-only 2024-11-21 14:37:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1514
No description provided.
Delete branch "fyrchik/frostfs-node:only-read-only"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?