TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

traverser: Check for placement vector out of range #1516

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/traverser-out-range into master 2024-11-21 11:27:53 +00:00
Conversation 0 Commits 1 Files changed 2 +49 -2
acid-ant commented 2024-11-21 10:18:35 +00:00
Member
Copy link

Placement vector may contain fewer nodes count than it required by policy
due to the outage of the one of the node.

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Placement vector may contain fewer nodes count than it required by policy due to the outage of the one of the node. Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 1 commit 2024-11-21 10:18:36 +00:00
[#xx] traverser: Check for placement vector out of range
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m39s
Details
DCO action / DCO (pull_request) Failing after 2m58s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m13s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m7s
Details
Tests and linters / gopls check (pull_request) Successful in 4m38s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m44s
Details
Build / Build Components (pull_request) Successful in 6m3s
Details
Tests and linters / Lint (pull_request) Successful in 6m26s
Details
Tests and linters / Tests (pull_request) Successful in 8m49s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m55s
Details
afacc86f35 
Placement vector may contain fewer nodes count than it required by policy
due to the outage of the one of the node.

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2024-11-21 10:18:47 +00:00
acid-ant requested review from storage-core-developers 2024-11-21 10:18:50 +00:00
acid-ant force-pushed bugfix/traverser-out-range from afacc86f35 to 9e11e3dc85 2024-11-21 10:19:22 +00:00 Compare
acid-ant force-pushed bugfix/traverser-out-range from 9e11e3dc85 to 6132971266 2024-11-21 10:19:52 +00:00 Compare
dstepanov-yadro reviewed 2024-11-21 10:35:08 +00:00
pkg/services/object_manager/placement/traverser.go Outdated
@ -117,2 +116,2 @@
unsortedVector = append(unsortedVector, ns[i][:rem[i]]...)
regularVector = append(regularVector, ns[i][rem[i]:]...)
if len(ns[i]) < rem[i] {
unsortedVector = append(unsortedVector, ns[i]...)
dstepanov-yadro commented 2024-11-21 10:35:08 +00:00
Member
Copy link

Looks like you have forgotten regularVector = append(regularVector, ns[i][rem[i]:]...) here

Looks like you have forgotten `regularVector = append(regularVector, ns[i][rem[i]:]...)` here
fyrchik commented 2024-11-21 10:37:11 +00:00
Owner
Copy link

But the like you wrote will panic!

But the like you wrote will panic!
dstepanov-yadro commented 2024-11-21 11:07:39 +00:00
Member
Copy link

I meant that the second slice is not updated.

I meant that the second slice is not updated.
acid-ant commented 2024-11-21 11:12:48 +00:00
Author
Member
Copy link

It should not because we do not have enough nodes for that in the current vector.

It should not because we do not have enough nodes for that in the current vector.
fyrchik reviewed 2024-11-21 10:37:22 +00:00
pkg/services/object_manager/placement/traverser.go Outdated
@ -113,3 +113,2 @@
rem = defaultCopiesVector(cfg.policy)
var unsortedVector []netmap.NodeInfo
var regularVector []netmap.NodeInfo
var unsortedVector, regularVector []netmap.NodeInfo
fyrchik commented 2024-11-21 10:35:39 +00:00
Owner
Copy link

Unrelated non-functional change, please, remove.

Unrelated non-functional change, please, remove.
fyrchik commented 2024-11-21 10:37:32 +00:00
Owner
Copy link

Other than this LGTM

Other than this LGTM
acid-ant commented 2024-11-21 10:46:26 +00:00
Author
Member
Copy link

Reverted.

Reverted.
acid-ant force-pushed bugfix/traverser-out-range from 6132971266 to bc1b4957e4 2024-11-21 10:46:13 +00:00 Compare
fyrchik reviewed 2024-11-21 10:57:13 +00:00
pkg/services/object_manager/placement/traverser.go Outdated
@ -116,3 +116,2 @@
for i := range rem {
unsortedVector = append(unsortedVector, ns[i][:rem[i]]...)
regularVector = append(regularVector, ns[i][rem[i]:]...)
if len(ns[i]) < rem[i] {
fyrchik commented 2024-11-21 10:57:13 +00:00
Owner
Copy link

Linter complains about the size of this function.
How about

pivot := min(len(ns[i]), rem[i])
unsortedVector = append(unsortedVector, ns[i][:pivot]...)
regularVector = append(regularVector, ns[i][pivot:]...)
Linter complains about the size of this function. How about ``` pivot := min(len(ns[i]), rem[i]) unsortedVector = append(unsortedVector, ns[i][:pivot]...) regularVector = append(regularVector, ns[i][pivot:]...) ```
👍 2
fyrchik commented 2024-11-21 11:00:38 +00:00
Owner
Copy link

It is also somewhat more readable and concise IMO

It is also somewhat more readable and concise IMO
acid-ant commented 2024-11-21 11:26:19 +00:00
Author
Member
Copy link

Nice! Updated.

Nice! Updated.
acid-ant force-pushed bugfix/traverser-out-range from bc1b4957e4 to 4d9d049e5a 2024-11-21 11:17:29 +00:00 Compare
acid-ant force-pushed bugfix/traverser-out-range from 4d9d049e5a to f12f04199e 2024-11-21 11:19:18 +00:00 Compare
fyrchik approved these changes 2024-11-21 11:21:34 +00:00
fyrchik merged commit f12f04199e into master 2024-11-21 11:27:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1516
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/traverser-out-range"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?