TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

[#1515] adm: Print address in base58 format in morph ape get-admin #1520

Merged
fyrchik merged 1 commit from george.bartolomey/frostfs-node:1-admin-base58 into master 2024-11-25 10:38:06 +00:00
Conversation 1 Commits 1 Files changed 1 +3 -3
george.bartolomey commented 2024-11-23 14:28:00 +00:00
Member
Copy link

Signed-off-by: George Bartolomey george@bh4.ru

Closes: #1515

Signed-off-by: George Bartolomey <george@bh4.ru> Closes: #1515
george.bartolomey added 1 commit 2024-11-23 14:28:01 +00:00
[#1515] adm: Print address in base58 format in morph ape get-admin
All checks were successful
DCO action / DCO (pull_request) Successful in 2m33s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m55s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m55s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m2s
Details
Build / Build Components (pull_request) Successful in 3m29s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m28s
Details
Tests and linters / Lint (pull_request) Successful in 3m49s
Details
Tests and linters / gopls check (pull_request) Successful in 4m7s
Details
Tests and linters / Tests (pull_request) Successful in 4m29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m47s
Details
4ea6cbbf61 
Signed-off-by: George Bartolomey <george@bh4.ru>
fyrchik requested changes 2024-11-25 06:53:52 +00:00
Dismissed
cmd/frostfs-adm/internal/modules/morph/ape/ape.go Outdated
@ -201,3 +202,3 @@
func setAdmin(cmd *cobra.Command, _ []string) {
s, _ := cmd.Flags().GetString(addrAdminFlag)
addr, err := util.Uint160DecodeStringLE(s)
addrBytes, err := base58.Decode(s)
fyrchik commented 2024-11-25 06:53:47 +00:00
Owner
Copy link

Please, look at the address package.
https://github.com/nspcc-dev/neo-go/blob/master/pkg/encoding/address/address.go

We shouldn't use base58 package directly here.

Please, look at the `address` package. https://github.com/nspcc-dev/neo-go/blob/master/pkg/encoding/address/address.go We shouldn't use base58 package directly here.
👍 1
fyrchik commented 2024-11-25 10:37:15 +00:00
Owner
Copy link

Please, don't resolve comments yourself, it is a burden of a reviewer.

Please, don't resolve comments yourself, it is a burden of a reviewer.
fyrchik marked this conversation as resolved
george.bartolomey force-pushed 1-admin-base58 from 4ea6cbbf61 to ceb916ce55 2024-11-25 08:15:08 +00:00 Compare
george.bartolomey requested review from fyrchik 2024-11-25 08:17:52 +00:00
aarifullin approved these changes 2024-11-25 08:30:46 +00:00
aarifullin left a comment
Member
Copy link

👍

👍
acid-ant commented 2024-11-25 09:53:56 +00:00
Member
Copy link

Please update commit message accordingly.

Please update commit message accordingly.
fyrchik approved these changes 2024-11-25 10:37:31 +00:00
fyrchik merged commit 0e5524dac7 into master 2024-11-25 10:38:06 +00:00
george.bartolomey deleted branch 1-admin-base58 2024-11-25 10:41:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1520
No description provided.
Delete branch "george.bartolomey/frostfs-node:1-admin-base58"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?