pilorama: Use AppendUint* helpers from stdlib #1525

Merged

fyrchik merged 1 commit from fyrchik/frostfs-node:patch-append into master

2024-11-28 07:49:54 +00:00

fyrchik commented

2024-11-28 06:16:44 +00:00

Owner

gopatch:

@@
var slice, e expression
@@
+import "encoding/binary"

-append(slice, byte(e), byte(e >> 8))
+binary.LittleEndian.AppendUint16(slice, e)

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

gopatch: ``` @@ var slice, e expression @@ +import "encoding/binary" -append(slice, byte(e), byte(e >> 8)) +binary.LittleEndian.AppendUint16(slice, e) ``` Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2024-11-28 06:16:45 +00:00

pilorama: Use AppendUint* helpers from stdlib

Tests and linters / Run gofumpt (pull_request) Successful in 2m10s

Details

DCO action / DCO (pull_request) Failing after 2m27s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 2m38s

Details

Vulncheck / Vulncheck (pull_request) Successful in 2m49s

Details

Build / Build Components (pull_request) Successful in 3m14s

Details

Tests and linters / gopls check (pull_request) Successful in 3m28s

Details

Tests and linters / Staticcheck (pull_request) Successful in 3m59s

Details

Tests and linters / Lint (pull_request) Successful in 4m37s

Details

Tests and linters / Tests (pull_request) Successful in 5m32s

Details

Tests and linters / Tests with -race (pull_request) Successful in 5m57s

Details

119c12f737

gopatch:
```
@@
var slice, e expression
@@
+import "encoding/binary"

-append(slice, byte(e), byte(e >> 8))
+binary.LittleEndian.AppendUint16(slice, e)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-developers 2024-11-28 06:16:57 +00:00

fyrchik requested review from storage-core-committers 2024-11-28 06:17:00 +00:00

fyrchik force-pushed patch-append from 119c12f737 to 2dde5f90a1

2024-11-28 06:21:26 +00:00

Compare