TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 106 Pull requests 12 Projects Releases 2 Activity Actions

[SUPPORT] node: Allow to omit metabase.path if shard is disabled #1532

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:fix-config-parsing into support/v0.44 2024-12-03 13:11:16 +00:00
Conversation 0 Commits 1 Files changed 5 +43 -4
fyrchik commented 2024-12-03 12:35:43 +00:00
Owner
Copy link

This looks like a kludge. Well it is, since with configuration in ENV we are unable to check whether the "section" is empty.
Otherwise, c.Value(si) == nil check would work.
I have also considered filtering all env data by prefix, but this is error-prone (because the same path could correspond to multiple sections).

I stayed with the current solution, because the changes to code are minimal and now it seems less wrong than before: we MUST have metabase.path, but we may omit it if the shard is unused.

This looks like a kludge. Well it is, since with configuration in ENV we are unable to check whether the "section" is empty. Otherwise, `c.Value(si) == nil` check would work. I have also considered filtering all env data by prefix, but this is error-prone (because the same path could correspond to multiple sections). I stayed with the current solution, because the changes to code are minimal and now it seems less wrong than before: we MUST have `metabase.path`, but we may omit it if the shard is unused.
fyrchik added 1 commit 2024-12-03 12:35:44 +00:00
node: Allow to omit metabase.path if shard is disabled
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m20s
Details
DCO action / DCO (pull_request) Failing after 2m34s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m35s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m2s
Details
Build / Build Components (pull_request) Successful in 3m17s
Details
Tests and linters / gopls check (pull_request) Successful in 3m33s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m48s
Details
Tests and linters / Lint (pull_request) Successful in 4m38s
Details
Tests and linters / Tests (pull_request) Successful in 5m9s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m25s
Details
b29a820b75 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2024-12-03 12:35:56 +00:00
a-savchuk approved these changes 2024-12-03 12:55:03 +00:00
cmd/frostfs-node/config/engine/config.go Outdated
@ -41,6 +41,10 @@ func IterateShards(c *config.Config, required bool, f func(*shardconfig.Config)
c.Sub(si),
)
if sc.Mode() == mode.Disabled {
a-savchuk commented 2024-12-03 12:54:59 +00:00
Member
Copy link

You can use sc.Mode().Disabled()

You can use `sc.Mode().Disabled()`
fyrchik commented 2024-12-03 13:03:27 +00:00
Author
Owner
Copy link

True, i wanted to leave changes to minimum.

True, i wanted to leave changes to minimum.
a-savchuk marked this conversation as resolved
aarifullin approved these changes 2024-12-03 12:57:59 +00:00
fyrchik force-pushed fix-config-parsing from b29a820b75 to 71dd82e7bd 2024-12-03 13:03:54 +00:00 Compare
fyrchik changed target branch from master to support/v0.44 2024-12-03 13:08:07 +00:00
fyrchik changed title from node: Allow to omit metabase.path if shard is disabled to [SUPPORT] node: Allow to omit metabase.path if shard is disabled 2024-12-03 13:08:16 +00:00
fyrchik merged commit 892542d6e3 into support/v0.44 2024-12-03 13:11:16 +00:00
fyrchik deleted branch fix-config-parsing 2024-12-03 13:11:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a-savchuk
aarifullin
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1532
No description provided.
Delete branch "fyrchik/frostfs-node:fix-config-parsing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?