TrueCloudLab/frostfs-node

Get rid of `could not` in the beginning of the wrapped error messages #1535

New issue

Open

opened 2024-12-04 08:20:54 +00:00 by fyrchik · 1 comment

fyrchik commented

2024-12-04 08:20:54 +00:00

Owner

It makes each error unreadable, while adding nothing to the context.
Same for failed to, same for can't.
Basically, what we did: %w.
https://github.com/uber-go/guide/blob/master/style.md#error-wrapping has more elaborate rationale.

The only way for error to be handled is logging and there we use either field name or level, so this context won't be lost.

It makes each error unreadable, while adding nothing to the context. Same for `failed to`, same for `can't`. Basically, `what we did: %w`. https://github.com/uber-go/guide/blob/master/style.md#error-wrapping has more elaborate rationale. The only way for error to be handled is logging and there we use either field name or level, so this context won't be lost.

fyrchik added the

labels 2024-12-04 08:20:54 +00:00

fyrchik self-assigned this 2024-12-04 08:21:05 +00:00

fyrchik commented

2024-12-04 08:22:29 +00:00

Author

Owner

The last part would be to find or create a linter which catches the most common verbs.

The last part would be to find or create a linter which catches the most common verbs.

fyrchik referenced this issue from a commit

2024-12-04 09:50:22 +00:00

[#1535] morph: Unify client creation error messages

fyrchik referenced this issue from a commit

2024-12-04 09:50:22 +00:00

[#1535] morph/netmap: Unify error messages for config retrieval

fyrchik referenced this issue from a commit

2024-12-04 09:50:23 +00:00

[#1535] morph: Unify test invoke error messages

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1535

No description provided.