TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 3 Projects Releases 1 Activity Actions

Remove notaryless code for side-chain contracts #1538

Merged
fyrchik merged 3 commits from fyrchik/frostfs-node:fix-notary into master 2024-12-05 08:09:16 +00:00
Conversation 0 Commits 3 Files changed 13 +29 -104
fyrchik commented 2024-12-04 12:30:43 +00:00
Owner
Copy link
No description provided.
fyrchik added 3 commits 2024-12-04 12:30:44 +00:00 
Notaryless environments are not tested at all since a while.
We use neo-go only and it has notary contract enabled.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
The notary is always enabled and this option does always work.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
morph/container: Make opts struct similar to that of other contracts
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 2m44s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 3m41s
Details
DCO action / DCO (pull_request) Failing after 4m1s
Details
Tests and linters / gopls check (pull_request) Successful in 4m55s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m8s
Details
Build / Build Components (pull_request) Successful in 5m21s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m7s
Details
Tests and linters / Lint (pull_request) Successful in 6m43s
Details
Tests and linters / Tests (pull_request) Successful in 7m46s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m51s
Details
1a5afd3774 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-12-04 12:30:54 +00:00
fyrchik requested review from storage-core-developers 2024-12-04 12:30:58 +00:00
fyrchik force-pushed fix-notary from 1a5afd3774 to 84b4051b4d 2024-12-04 12:31:03 +00:00 Compare
acid-ant approved these changes 2024-12-04 13:02:15 +00:00
fyrchik changed title from Remove notary code for side-chain contracts to Remove notaryless code for side-chain contracts 2024-12-05 08:02:57 +00:00
fyrchik added this to the v0.45.0 milestone 2024-12-05 08:03:04 +00:00
dstepanov-yadro approved these changes 2024-12-05 08:03:57 +00:00
fyrchik merged commit 84b4051b4d into master 2024-12-05 08:09:16 +00:00
fyrchik deleted branch fix-notary 2024-12-05 08:09:18 +00:00
elebedeva approved these changes 2024-12-05 08:12:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
elebedeva
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.45.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1538
No description provided.
Delete branch "fyrchik/frostfs-node:fix-notary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?