TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 108 Pull requests 8 Projects Releases 2 Activity Actions

Bump frostfs-sdk-go version #1539

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/grpc_healthcheck into master 2024-12-06 13:25:15 +00:00
Conversation 0 Commits 1 Files changed 3 +7 -4
aarifullin commented 2024-12-04 14:06:17 +00:00
Member
Copy link

This frostfs-sdk-go contains fixes for rpc client

This `frostfs-sdk-go` contains fixes for rpc client
requested reviews from storage-core-committers, storage-core-developers 2024-12-04 14:07:22 +00:00
aarifullin force-pushed fix/grpc_healthcheck from 3bccdef093 to 7eb557f4c8 2024-12-04 14:08:11 +00:00 Compare
aarifullin changed title from Make SearchObject check the grpc service health in the raw execution to WIP: Make SearchObject check the grpc service health in the raw execution 2024-12-04 14:54:23 +00:00
fyrchik reviewed 2024-12-05 07:46:51 +00:00
pkg/services/object/search/v2/request_forwarder.go Outdated
@ -25,6 +29,21 @@ type requestForwarder struct {
Key *ecdsa.PrivateKey
}
func rpcSearchDialer(ctx context.Context, cc grpc.ClientConnInterface) error {
fyrchik commented 2024-12-05 07:46:51 +00:00
Owner
Copy link

I believe this healthcheck can be integrated natively in the gRPC -- could you please look at the connection options?
I think balancer is responsible for checking health.

I believe this healthcheck can be integrated natively in the gRPC -- could you please look at the connection options? I think balancer is responsible for checking health.
aarifullin force-pushed fix/grpc_healthcheck from 7eb557f4c8 to 65ace5df48 2024-12-06 11:44:53 +00:00 Compare
aarifullin changed title from WIP: Make SearchObject check the grpc service health in the raw execution to Bump frostfs-sdk-go version 2024-12-06 11:45:11 +00:00
aarifullin force-pushed fix/grpc_healthcheck from 65ace5df48 to b8c3a6e53e 2024-12-06 11:49:12 +00:00 Compare
fyrchik approved these changes 2024-12-06 11:57:25 +00:00
Dismissed
aarifullin dismissed fyrchik's review 2024-12-06 12:10:41 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-12-06 12:20:34 +00:00
Dismissed
aarifullin force-pushed fix/grpc_healthcheck from dd9eabfcdd to 89e8a117e5 2024-12-06 12:21:59 +00:00 Compare
fyrchik approved these changes 2024-12-06 12:22:10 +00:00
elebedeva approved these changes 2024-12-06 12:23:25 +00:00
aarifullin force-pushed fix/grpc_healthcheck from 89e8a117e5 to 7e542906ef 2024-12-06 12:29:58 +00:00 Compare
requested reviews from fyrchik, acid-ant, elebedeva 2024-12-06 12:31:03 +00:00
acid-ant approved these changes 2024-12-06 12:45:56 +00:00
fyrchik merged commit 7e542906ef into master 2024-12-06 13:25:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
elebedeva
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1539
No description provided.
Delete branch "aarifullin/frostfs-node:fix/grpc_healthcheck"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?