TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

morph/event: Reuse auto-generated parsers #1541

Merged
fyrchik merged 4 commits from fyrchik/frostfs-node:fix-event-parsing into master 2024-12-06 10:26:40 +00:00
Conversation 0 Commits 4 Files changed 10 +59 -138
fyrchik commented 2024-12-05 13:21:03 +00:00
Owner
Copy link

Designate event could've also been parsed, but it is a native contract and for some reason StackItem() method is not present.

Testing done: devenv start, put+get container.

Designate event could've also been parsed, but it is a native contract and for some reason `StackItem()` method is not present. Testing done: devenv start, put+get container.
fyrchik added 4 commits 2024-12-05 13:21:04 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
New version contains more idiomatic types in the auto-generated code.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
morph/event: Simplify netmap contract event parsing
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m12s
Details
DCO action / DCO (pull_request) Failing after 2m43s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m20s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m40s
Details
Build / Build Components (pull_request) Successful in 5m1s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m36s
Details
Tests and linters / Lint (pull_request) Successful in 6m18s
Details
Tests and linters / gopls check (pull_request) Successful in 6m18s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m30s
Details
Tests and linters / Tests (pull_request) Successful in 6m58s
Details
409a678089 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed fix-event-parsing from 409a678089 to a2423de5ce 2024-12-05 13:21:40 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-12-05 13:25:43 +00:00
fyrchik requested review from storage-core-developers 2024-12-05 13:25:47 +00:00
dstepanov-yadro approved these changes 2024-12-06 10:14:28 +00:00
aarifullin approved these changes 2024-12-06 10:17:45 +00:00
fyrchik merged commit 1c12f23b84 into master 2024-12-06 10:26:40 +00:00
fyrchik deleted branch fix-event-parsing 2024-12-06 10:26:42 +00:00
acid-ant approved these changes 2024-12-06 10:26:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1541
No description provided.
Delete branch "fyrchik/frostfs-node:fix-event-parsing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?