TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 12 Projects Releases 2 Activity Actions

morph/event: Remove more code #1546

Merged
fyrchik merged 4 commits from fyrchik/frostfs-node:fix-events into master 2024-12-11 07:39:50 +00:00
Conversation 0 Commits 4 Files changed 13 +83 -318
fyrchik commented 2024-12-06 13:25:52 +00:00
Owner
Copy link
No description provided.
fyrchik added 4 commits 2024-12-06 13:25:52 +00:00 
This codepath hides possible bugs in code.
We would rather panic then silently fail.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This codepath hides possible bugs in code.
All initialization function should run before init stage.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
They are decoupled, but it is an error to have a handler without a
corresponding parser. Register them together on the code level and get
rid of unreachable code.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
morph/event: Export NotificationHandlerInfo fields
Some checks failed
DCO action / DCO (pull_request) Failing after 3m46s
Details
Build / Build Components (pull_request) Successful in 4m38s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m34s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 5m26s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m39s
Details
Tests and linters / Lint (pull_request) Successful in 6m19s
Details
Vulncheck / Vulncheck (pull_request) Successful in 6m28s
Details
Tests and linters / gopls check (pull_request) Successful in 8m55s
Details
Tests and linters / Tests (pull_request) Successful in 10m37s
Details
Tests and linters / Tests with -race (pull_request) Successful in 10m50s
Details
148cc83ed5 
Hiding them achieves nothing, as the struct has no methods and is not
used concurrently.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed fix-events from 148cc83ed5 to d79ec20084 2024-12-06 13:26:24 +00:00 Compare
fyrchik force-pushed fix-events from d79ec20084 to 985be9aef7 2024-12-06 13:37:19 +00:00 Compare
requested reviews from storage-core-committers, storage-core-developers 2024-12-07 08:09:54 +00:00
acid-ant approved these changes 2024-12-08 06:39:13 +00:00
dstepanov-yadro approved these changes 2024-12-11 07:35:56 +00:00
fyrchik merged commit b1614a284d into master 2024-12-11 07:39:50 +00:00
fyrchik deleted branch fix-events 2024-12-11 07:39:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1546
No description provided.
Delete branch "fyrchik/frostfs-node:fix-events"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?