node: Possibly incorrect log level is used #1547
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1547
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is your feature request related to a problem? Please describe.
I believe these messages should have
Error
level instead ofInfo
if err != nil {
c.log.Info(ctx, logs.FrostFSNodeFailedToCreateNeoRPCClient,
zap.Any("endpoints", addresses),
zap.String("error", err.Error()),
)
if err := cli.SetGroupSignerScope(); err != nil {
c.log.Info(ctx, logs.FrostFSNodeFailedToSetGroupSignerScopeContinueWithGlobal, zap.Error(err))
}
Describe the solution you'd like
Use
Error
log level instead ofInfo
Describe alternatives you've considered
Leave as is if the log level was chosen intentionally
Maybe the second one should have
Warn
because it doesn't fail on an errorcmd/node: Possibly incorrect log level usedto node: Possibly incorrect log level usednode: Possibly incorrect log level usedto node: Possibly incorrect log level is usedIn the first case
fatalOnErr
should already print something, but it useslog
package.We should not print the same error twice.