TrueCloudLab/frostfs-node

Fork 27

metabase: Fix broken benchmarks #1560

Merged

fyrchik merged 2 commits from a-savchuk/frostfs-node:fix-benchmarks into master

2024-12-16 07:43:27 +00:00

a-savchuk commented

2024-12-13 10:18:19 +00:00

Member

Close #1510

Fixed the following benchmarks:

BenchmarkGet
- Fix misplaced (*DB).Close (broken after 47dcfa20f3)
BenchmarkListWithCursor
- Fix misplaced (*DB).Close (broken after 47dcfa20f3)
- Use errors.Is for error checking (broken after fcdbf5e509)

Now everything is fine

$ go test -run=^$ -bench=Benchmark* -benchtime=1x ./... | grep -cE "FAIL: Benchmark"
0

Close #1510 Fixed the following benchmarks: - `BenchmarkGet` - Fix misplaced `(*DB).Close` (broken after 47dcfa20f3) - `BenchmarkListWithCursor` - Fix misplaced `(*DB).Close` (broken after 47dcfa20f3) - Use `errors.Is` for error checking (broken after fcdbf5e509) Now everything is fine ```console $ go test -run=^$ -bench=Benchmark* -benchtime=1x ./... | grep -cE "FAIL: Benchmark" 0 ```

a-savchuk added 2 commits 2024-12-13 10:18:20 +00:00

[#1510 ] metabase/test: Fix BenchmarkGet d6fedfbd62

Fix misplaced `(*DB).Close`

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>

[#1510 ] metabase/test: Fix BenchmarkListWithCursor

Tests and linters / Run gofumpt (pull_request) Successful in 2m18s

Details

DCO action / DCO (pull_request) Successful in 2m56s

Details

Tests and linters / Staticcheck (pull_request) Successful in 3m51s

Details

Vulncheck / Vulncheck (pull_request) Successful in 5m49s

Details

Tests and linters / Lint (pull_request) Successful in 6m4s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 6m22s

Details

Tests and linters / Tests (pull_request) Successful in 6m52s

Details

Build / Build Components (pull_request) Successful in 7m6s

Details

Tests and linters / Tests with -race (pull_request) Successful in 7m0s

Details

Tests and linters / gopls check (pull_request) Successful in 7m49s

Details

a92334836f

- Fix misplaced `(*DB).Close`
- Use `errors.Is` for error checking

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>

a-savchuk requested review from storage-core-committers 2024-12-13 10:18:20 +00:00

a-savchuk requested review from storage-core-developers 2024-12-13 10:18:20 +00:00

a-savchuk force-pushed fix-benchmarks from a92334836f to 8ba9f31fca

2024-12-13 10:19:53 +00:00

Compare

acid-ant approved these changes 2024-12-16 05:53:41 +00:00

aarifullin approved these changes 2024-12-16 06:08:47 +00:00

fyrchik approved these changes 2024-12-16 07:43:16 +00:00

fyrchik merged commit 8ba9f31fca into master

2024-12-16 07:43:27 +00:00

a-savchuk deleted branch fix-benchmarks

2024-12-16 08:46:37 +00:00

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1560

No description provided.