TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 103 Pull requests 4 Projects Releases 2 Activity Actions

cli: Make --range flag required in object hash #1569

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:fix-object-hash into master 2024-12-18 12:16:18 +00:00
Conversation 0 Commits 2 Files changed 1 +3 -32
fyrchik commented 2024-12-18 07:07:53 +00:00
Owner
Copy link

Previously, object head was used if no range was provided.
This is wrong on multiple levels:

  1. We print an error if the checksum is missing in header,
    even though taking hash is possible.
  2. We silently ignore --salt parameter.
  3. --range is required for Object.RANGEHASH RPC, custom logic for one
    specific usecase has no value.

So we make it required and make CLI command follow more closely
the FrostFS API.

Previously, `object head` was used if no range was provided. This is wrong on multiple levels: 1. We print an error if the checksum is missing in header, even though taking hash is possible. 2. We silently ignore --salt parameter. 3. `--range` is required for Object.RANGEHASH RPC, custom logic for one specific usecase has no value. So we make it required and make CLI command follow more closely the FrostFS API.
fyrchik added 2 commits 2024-12-18 07:07:54 +00:00 
Previously, `object head` was used if no range was provided.
This is wrong on multiple levels:
1. We print an error if the checksum is missing in header,
   even though taking hash is possible.
2. We silently ignore --salt parameter.
3. `--range` is required for Object.RANGEHASH RPC, custom logic for one
   specific usecase has no value.

So we make it required and make CLI command follow more closely
the FrostFS API.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
cli: Remove unnecessary variable after refactoring
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 3m3s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m37s
Details
Tests and linters / gopls check (pull_request) Successful in 3m59s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 6m11s
Details
DCO action / DCO (pull_request) Failing after 6m40s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m41s
Details
Build / Build Components (pull_request) Successful in 7m30s
Details
Tests and linters / Tests (pull_request) Successful in 7m44s
Details
Tests and linters / Staticcheck (pull_request) Successful in 7m57s
Details
Tests and linters / Lint (pull_request) Successful in 8m42s
Details
98c789c3ee 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-12-18 07:07:54 +00:00
fyrchik requested review from storage-core-developers 2024-12-18 07:07:54 +00:00
fyrchik force-pushed fix-object-hash from 98c789c3ee to e44b84c18c 2024-12-18 07:17:09 +00:00 Compare
aarifullin approved these changes 2024-12-18 07:45:14 +00:00
elebedeva approved these changes 2024-12-18 11:42:23 +00:00
fyrchik merged commit e44b84c18c into master 2024-12-18 12:16:18 +00:00
fyrchik deleted branch fix-object-hash 2024-12-18 12:16:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
elebedeva
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1569
No description provided.
Delete branch "fyrchik/frostfs-node:fix-object-hash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?