fix gitlint run in CI #158

realloc · 2023-03-22T06:33:03Z

realloc commented

2023-03-22 06:33:03 +00:00

Gitlint check was missing

woodpecker changed title from ~~fix gitlint run in CI~~ to WIP: fix gitlint run in CI

2023-03-22 06:48:14 +00:00

realloc force-pushed fix/gitlint from b272b0df48 to 16f249f635

2023-03-22 07:26:05 +00:00

Compare

realloc force-pushed fix/gitlint from 16f249f635 to 511a70f1aa

2023-03-22 07:38:06 +00:00

Compare

woodpecker changed title from ~~WIP: fix gitlint run in CI~~ to fix gitlint run in CI

2023-03-22 07:39:39 +00:00

realloc force-pushed fix/gitlint from 511a70f1aa to 3f334e98ef

2023-03-22 07:44:39 +00:00

Compare

realloc referenced this pull request

2023-03-22 08:01:00 +00:00

Add bug label into bug reposts #154

realloc requested review from storage-core-committers 2023-03-22 08:01:32 +00:00

realloc requested review from storage-core-developers 2023-03-22 08:01:32 +00:00

dstepanov-yadro approved these changes 2023-03-22 08:04:09 +00:00

fyrchik reviewed 2023-03-22 08:31:08 +00:00

.gitlint

					
				@ -1,6 +1,6 @@

				[general]

				fail-without-commits=true

				regex-style-search=true

				fail-without-commits=True

fyrchik commented

2023-03-22 08:31:02 +00:00

The official doc mentions small letters, do we need this change?
https://jorisroovers.com/gitlint/configuration/

The official doc mentions small letters, do we need this change? https://jorisroovers.com/gitlint/configuration/

realloc commented

2023-03-22 08:36:59 +00:00

Agree, but the internal representation uses capital letters, so the warning shown from binary request changes with capital letters =) Both ways work.

DEBUG: gitlint.cli Configuration
config-path: /home/realloc/projects/tcl-realloc/frostfs-node/.gitlint
[GENERAL]
extra-path: None
contrib: ['CC1']
ignore: 
ignore-merge-commits: True
ignore-fixup-commits: True
ignore-fixup-amend-commits: True
ignore-squash-commits: True
ignore-revert-commits: True
ignore-stdin: False
staged: False
fail-without-commits: True
regex-style-search: True
verbosity: 3
debug: True

Agree, but the internal representation uses capital letters, so the warning shown from binary request changes with capital letters =) Both ways work. ``` DEBUG: gitlint.cli Configuration config-path: /home/realloc/projects/tcl-realloc/frostfs-node/.gitlint [GENERAL] extra-path: None contrib: ['CC1'] ignore: ignore-merge-commits: True ignore-fixup-commits: True ignore-fixup-amend-commits: True ignore-squash-commits: True ignore-revert-commits: True ignore-stdin: False staged: False fail-without-commits: True regex-style-search: True verbosity: 3 debug: True ```