TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 103 Pull requests 3 Projects Releases 2 Activity Actions

metabase: Skip expired objects in ListWithCursor #1583

Merged
fyrchik merged 2 commits from a-savchuk/frostfs-node:do-not-list-expired-objects into master 2024-12-27 05:42:07 +00:00
Conversation 0 Commits 2 Files changed 2 +45 -10
a-savchuk commented 2024-12-25 19:30:24 +00:00
Member
Copy link

Before this change, the result of ListWithCursor included expired objects. This caused unnecessary attempts by the replicator to replicate these objects, leading to errors like this one below:

aug 06 11:56:12 node frostfs-node[4795]: 2024-08-06T11:56:12.630Z error replicator/process.go:78 could not replicate object {"component": "Object Replicator", "node": "03c5d517303e09d058371c03098becf5fc4089e301aa64d1e6f41602b11dd7b50f", "object": "H6esfqFaG3AcmdQnZ7UBKVQ38zpyUEt5nq4gAhHKDMFR/GQ3yizn5sCaTGrTGNzWgjQ6GADPRjCdANVRKyBiphHX2", "trace_id": "", "error": "(*putsvc.RemoteSender) could not send object: (*putsvc.remoteTarget) could not put single object to [/ip4/10.252.11.12/tcp/8080]: put single object via client: status: code = 1024 message = object has expired"}
Before this change, the result of `ListWithCursor` included expired objects. This caused unnecessary attempts by the replicator to replicate these objects, leading to errors like this one below: ``` aug 06 11:56:12 node frostfs-node[4795]: 2024-08-06T11:56:12.630Z error replicator/process.go:78 could not replicate object {"component": "Object Replicator", "node": "03c5d517303e09d058371c03098becf5fc4089e301aa64d1e6f41602b11dd7b50f", "object": "H6esfqFaG3AcmdQnZ7UBKVQ38zpyUEt5nq4gAhHKDMFR/GQ3yizn5sCaTGrTGNzWgjQ6GADPRjCdANVRKyBiphHX2", "trace_id": "", "error": "(*putsvc.RemoteSender) could not send object: (*putsvc.remoteTarget) could not put single object to [/ip4/10.252.11.12/tcp/8080]: put single object via client: status: code = 1024 message = object has expired"} ```
a-savchuk added 3 commits 2024-12-25 19:30:25 +00:00 
The function is riskly long. so adding just a few lines of code
might trigger the `funlen` linter. Kept the changes minimal:
- Moved the logic for filling object info into a separate function
- Preserved all existing side effects

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
[#xx] metabase/test: Update TestLisObjectsWithCursor
Some checks failed
DCO action / DCO (pull_request) Failing after 4m27s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m48s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 5m1s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m44s
Details
Build / Build Components (pull_request) Successful in 6m11s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m10s
Details
Tests and linters / gopls check (pull_request) Successful in 6m23s
Details
Tests and linters / Tests (pull_request) Successful in 6m33s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m39s
Details
Tests and linters / Lint (pull_request) Successful in 7m3s
Details
c926fe4065 
Update this test following recent changes to ensure
that `(*DB).ListWithCursor` skips expired objects.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed do-not-list-expired-objects from c926fe4065 to 967072e52d 2024-12-25 19:32:53 +00:00 Compare
a-savchuk force-pushed do-not-list-expired-objects from 967072e52d to 2473257925 2024-12-25 19:38:32 +00:00 Compare
a-savchuk changed title from WIP: metabase: Skip expired objects in ListWithCursor to metabase: Skip expired objects in ListWithCursor 2024-12-25 19:50:36 +00:00
a-savchuk requested review from storage-core-committers 2024-12-25 19:50:37 +00:00
a-savchuk requested review from storage-core-developers 2024-12-25 19:50:37 +00:00
a-savchuk force-pushed do-not-list-expired-objects from 2473257925 to b49ce50daa 2024-12-25 19:59:55 +00:00 Compare
a-savchuk force-pushed do-not-list-expired-objects from b49ce50daa to dffae78eb2 2024-12-25 21:07:17 +00:00 Compare
fyrchik requested changes 2024-12-26 06:43:28 +00:00
Dismissed
fyrchik left a comment
Owner
Copy link

Please, look at the already existing fix which was not in master for some reason 284b270c1f
It seems shorter and handles expired but locked objects (which thus should be available).
There should be tests for expired but locked objects too.

Please, look at the already existing fix which was not in master for some reason https://git.frostfs.info/fyrchik/frostfs-node/commit/284b270c1f1c5e17c6bd9a63f540d1dc14a633e9 It seems shorter and handles expired but locked objects (which thus should be available). There should be tests for expired but locked objects too.
pkg/local_object_storage/metabase/list.go Outdated
@ -125,3 +128,3 @@
}
func (db *DB) listWithCursor(tx *bbolt.Tx, result []objectcore.Info, count int, cursor *Cursor) ([]objectcore.Info, *Cursor, error) {
func (db *DB) listWithCursor(ctx context.Context, tx *bbolt.Tx, result []objectcore.Info, count int, cursor *Cursor) ([]objectcore.Info, *Cursor, error) {
fyrchik commented 2024-12-26 06:38:46 +00:00
Owner
Copy link

Please, let's not have any ctx in unexported function of the metabase package.
It is unnecessary an complicates code.

Please, let's not have any `ctx` in unexported function of the metabase package. It is unnecessary an complicates code.
a-savchuk commented 2024-12-26 08:22:01 +00:00
Author
Member
Copy link

Fixed

Fixed
pkg/local_object_storage/metabase/list.go Outdated
@ -225,6 +234,9 @@ func selectNFromBucket(bkt *bbolt.Bucket, // main bucket
if !threshold {
c.Seek(offset)
// TODO(@a-savchuk): What'd be if the object with this offset was
fyrchik commented 2024-12-26 06:39:39 +00:00
Owner
Copy link

What do we need to do in this TODO?

What do we need to do in this TODO?
a-savchuk commented 2024-12-26 08:25:08 +00:00
Author
Member
Copy link

If we can't decode one object ID, we skip the rest of the bucket. We can't log this error. I'm not sure, maybe use continue?

If we can't decode one object ID, we skip the rest of the bucket. We can't log this error. I'm not sure, maybe use `continue`?
fyrchik commented 2024-12-26 11:32:19 +00:00
Owner
Copy link

It is unrelated to the PR, please create an issue instead.

It is unrelated to the PR, please create an issue instead.
👍 1
fyrchik marked this conversation as resolved
a-savchuk force-pushed do-not-list-expired-objects from dffae78eb2 to 3260fd60b3 2024-12-26 08:13:29 +00:00 Compare
a-savchuk force-pushed do-not-list-expired-objects from 3260fd60b3 to fa08bfa553 2024-12-26 11:39:56 +00:00 Compare
fyrchik approved these changes 2024-12-26 11:55:38 +00:00
aarifullin approved these changes 2024-12-26 13:26:42 +00:00
fyrchik merged commit fa08bfa553 into master 2024-12-27 05:42:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1583
No description provided.
Delete branch "a-savchuk/frostfs-node:do-not-list-expired-objects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?