TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 11 Projects Releases 2 Activity Actions

Await tx in ape_manager.AddChain/RemoveChain #1587

Merged
fyrchik merged 4 commits from fyrchik/frostfs-node:fix-ape-await into master 2025-01-09 12:04:24 +00:00
Conversation 0 Commits 4 Files changed 6 +57 -41
fyrchik commented 2024-12-28 06:54:50 +00:00
Owner
Copy link

Close #1506
Testing done: check time spent in frostfs-cli ape-manager add-chain in dev-env with increased block time.

Close #1506 Testing done: check time spent in `frostfs-cli ape-manager add-chain` in dev-env with increased block time.
fyrchik added 3 commits 2024-12-28 06:54:50 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
[#1506] ape_manager: Await tx persist before returning response
Some checks failed
DCO action / DCO (pull_request) Successful in 48s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m30s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m36s
Details
Build / Build Components (pull_request) Successful in 2m3s
Details
Tests and linters / Lint (pull_request) Failing after 1m57s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m58s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m18s
Details
Tests and linters / Tests (pull_request) Successful in 2m33s
Details
Tests and linters / gopls check (pull_request) Successful in 2m33s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m45s
Details
74a938dd4b 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2024-12-28 06:54:51 +00:00
fyrchik force-pushed fix-ape-await from 74a938dd4b to dcd8c20952 2024-12-28 07:08:10 +00:00 Compare
fyrchik force-pushed fix-ape-await from dcd8c20952 to 21ab3d5251 2024-12-28 07:23:39 +00:00 Compare
fyrchik force-pushed fix-ape-await from 21ab3d5251 to 7bb9e9fe30 2024-12-28 07:24:12 +00:00 Compare
dstepanov-yadro approved these changes 2025-01-09 06:33:42 +00:00
requested reviews from storage-core-committers, storage-core-developers 2025-01-09 06:55:33 +00:00
fyrchik merged commit f7e75b13b0 into master 2025-01-09 12:04:24 +00:00
fyrchik deleted branch fix-ape-await 2025-01-13 07:19:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1587
No description provided.
Delete branch "fyrchik/frostfs-node:fix-ape-await"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?