TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 103 Pull requests 5 Projects Releases 2 Activity Actions

node: Fix initialization of frostfsid cache #1594

Merged
fyrchik merged 2 commits from achuprov/frostfs-node:bugfix/frostfsid_cache into master 2025-01-13 06:38:47 +00:00
Conversation 1 Commits 2 Files changed 2 +3 -2
achuprov commented 2025-01-09 17:40:28 +00:00
Member
Copy link

Close #1593
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1593 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2025-01-09 17:40:28 +00:00
[#1593] node: Fix initialization of frostfsid cache
All checks were successful
DCO action / DCO (pull_request) Successful in 34s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 28s
Details
Vulncheck / Vulncheck (pull_request) Successful in 54s
Details
Build / Build Components (pull_request) Successful in 1m28s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m47s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m59s
Details
Tests and linters / Tests (pull_request) Successful in 2m44s
Details
Tests and linters / Lint (pull_request) Successful in 2m53s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m22s
Details
Tests and linters / gopls check (pull_request) Successful in 3m25s
Details
4237297543 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2025-01-09 17:40:29 +00:00
achuprov requested review from storage-core-developers 2025-01-09 17:40:29 +00:00
fyrchik approved these changes 2025-01-10 07:47:17 +00:00
Dismissed
cmd/frostfs-node/container.go Outdated
@ -44,3 +44,3 @@
cacheSize := morphconfig.FrostfsIDCacheSize(c.appCfg)
if cacheSize > 0 {
if cacheSize > 0 && c.cfgMorph.cacheTTL >= 0 {
fyrchik commented 2025-01-10 07:47:14 +00:00
Owner
Copy link

What does == 0 mean?

What does `== 0` mean?
achuprov commented 2025-01-10 12:08:15 +00:00
Author
Member
Copy link

You are right, 0 is not allowed. When TTL=0, the default value is set

You are right, 0 is not allowed. When TTL=0, the default value is [set](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/cmd/frostfs-node/morph.go#L55)
fyrchik commented 2025-01-10 07:49:20 +00:00
Owner
Copy link

cmd/frostfs-node/config/morph.CacheTTL() has a comment Supports negative durations..
I do not see a value in this -- probably another place that needs fix.

`cmd/frostfs-node/config/morph.CacheTTL()` has a comment `Supports negative durations.`. I do not see a value in this -- probably another place that needs fix.
aarifullin approved these changes 2025-01-10 08:32:21 +00:00
Dismissed
achuprov force-pushed bugfix/frostfsid_cache from 4237297543 to 3f419166fb 2025-01-10 12:00:50 +00:00 Compare
achuprov dismissed fyrchik's review 2025-01-10 12:00:51 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed aarifullin's review 2025-01-10 12:00:51 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov force-pushed bugfix/frostfsid_cache from 3f419166fb to 3929c9acd5 2025-01-10 12:01:58 +00:00 Compare
achuprov force-pushed bugfix/frostfsid_cache from 3929c9acd5 to 7cf42a61d5 2025-01-10 12:12:43 +00:00 Compare
achuprov force-pushed bugfix/frostfsid_cache from 7cf42a61d5 to a2485637bb 2025-01-10 12:13:25 +00:00 Compare
acid-ant approved these changes 2025-01-10 14:26:22 +00:00
fyrchik approved these changes 2025-01-13 06:38:16 +00:00
fyrchik merged commit a2485637bb into master 2025-01-13 06:38:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1594
No description provided.
Delete branch "achuprov/frostfs-node:bugfix/frostfsid_cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?