TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 8 Projects Releases 2 Activity Actions 1

metrics: Create public aliases for internal engine metrics #1596

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/ref-met into master 2025-01-13 10:05:02 +00:00
Conversation 1 Commits 1 Files changed 1 +11 -33
acid-ant commented 2025-01-10 11:07:36 +00:00
Member
Copy link

These changes are needed to updated k6 in scope of TrueCloudLab/xk6-frostfs#187

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

These changes are needed to updated `k6` in scope of https://git.frostfs.info/TrueCloudLab/xk6-frostfs/issues/187 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 1 commit 2025-01-10 11:07:36 +00:00
[#xx] metrics: Extract gc and writecache metrics from engine
Some checks failed
DCO action / DCO (pull_request) Failing after 30s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 33s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m17s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m26s
Details
Build / Build Components (pull_request) Successful in 1m24s
Details
Tests and linters / Tests (pull_request) Successful in 2m58s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m7s
Details
Tests and linters / Lint (pull_request) Successful in 3m10s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m11s
Details
Tests and linters / gopls check (pull_request) Successful in 3m27s
Details
1f1d95b01f 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-developers 2025-01-10 11:07:37 +00:00
acid-ant requested review from storage-core-committers 2025-01-10 11:07:37 +00:00
acid-ant force-pushed bugfix/ref-met from 1f1d95b01f to 9307909ea6 2025-01-10 11:09:06 +00:00 Compare
fyrchik requested changes 2025-01-10 11:31:32 +00:00
Dismissed
fyrchik left a comment
Owner
Copy link

How about this:
engine package:

type Metrics = internal.Metrics
type GCMetrics = internal.GCMetrics

In k6:

func (...) GC() engine.GCMetrics { ... }

So just add 4 aliases in this PR (3 metrics interfaces, 1 type).

How about this: `engine` package: ``` type Metrics = internal.Metrics type GCMetrics = internal.GCMetrics ``` In k6: ``` func (...) GC() engine.GCMetrics { ... } ``` So just add 4 aliases in this PR (3 metrics interfaces, 1 type).
internal/metrics/node.go Outdated
@ -79,6 +79,14 @@ func (m *NodeMetrics) Engine() EngineMetrics {
return m.engine
}
func (m *NodeMetrics) Writecachce() WriteCacheMetrics {
fyrchik commented 2025-01-10 11:17:09 +00:00
Owner
Copy link

s/cachce/cache/

s/cachce/cache/
acid-ant commented 2025-01-10 13:18:04 +00:00
Author
Member
Copy link

Fixed.

Fixed.
internal/metrics/types.go Outdated
@ -6,4 +0,0 @@
type NullBool struct {
Bool bool
Valid bool // Valid is true if Bool is not NULL
fyrchik commented 2025-01-10 11:17:40 +00:00
Owner
Copy link

This change seems unnecessary. It was a proper type, is a string now.

This change seems unnecessary. It was a proper type, is a string now.
acid-ant commented 2025-01-10 13:18:14 +00:00
Author
Member
Copy link

Reverted.

Reverted.
acid-ant force-pushed bugfix/ref-met from 9307909ea6 to a0b9b86394 2025-01-10 13:13:22 +00:00 Compare
acid-ant force-pushed bugfix/ref-met from a0b9b86394 to 6bc751f686 2025-01-10 13:16:23 +00:00 Compare
acid-ant commented 2025-01-10 13:20:02 +00:00
Author
Member
Copy link

How about this:
engine package:

type Metrics = internal.Metrics
type GCMetrics = internal.GCMetrics

In k6:

func (...) GC() engine.GCMetrics { ... }

So just add 4 aliases in this PR (3 metrics interfaces, 1 type).

Agree with you, this approach is much simpler.

> How about this: > `engine` package: > ``` > type Metrics = internal.Metrics > type GCMetrics = internal.GCMetrics > ``` > > In k6: > ``` > func (...) GC() engine.GCMetrics { ... } > ``` > > So just add 4 aliases in this PR (3 metrics interfaces, 1 type). Agree with you, this approach is much simpler.
acid-ant requested review from fyrchik 2025-01-10 14:12:11 +00:00
acid-ant requested review from storage-core-committers 2025-01-10 14:12:17 +00:00
acid-ant requested review from storage-core-developers 2025-01-10 14:12:17 +00:00
a-savchuk approved these changes 2025-01-13 06:28:47 +00:00
Dismissed
fyrchik reviewed 2025-01-13 06:32:50 +00:00
internal/metrics/engine.go Outdated
@ -29,4 +29,2 @@
SetRefillStatus(shardID, path, status string)
SetEvacuationInProgress(shardID string, value bool)
WriteCache() WriteCacheMetrics
fyrchik commented 2025-01-13 06:32:49 +00:00
Owner
Copy link

These is no need to remove them now, right?

These is no need to remove them now, right?
acid-ant commented 2025-01-13 09:55:42 +00:00
Author
Member
Copy link

Right, redundant changes were removed.

Right, redundant changes were removed.
dstepanov-yadro approved these changes 2025-01-13 08:33:40 +00:00
Dismissed
achuprov approved these changes 2025-01-13 08:44:09 +00:00
Dismissed
acid-ant force-pushed bugfix/ref-met from 6bc751f686 to 84141702eb 2025-01-13 09:54:25 +00:00 Compare
acid-ant dismissed a-savchuk's review 2025-01-13 09:54:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant dismissed dstepanov-yadro's review 2025-01-13 09:54:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant dismissed achuprov's review 2025-01-13 09:54:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant changed title from metrics: Extract gc and writecache metrics from engine to metrics: Create public aliases for internal engine metrics 2025-01-13 09:54:52 +00:00
acid-ant requested review from storage-core-committers 2025-01-13 10:02:43 +00:00
acid-ant requested review from storage-core-developers 2025-01-13 10:02:44 +00:00
fyrchik approved these changes 2025-01-13 10:04:54 +00:00
fyrchik merged commit 6c51f48aab into master 2025-01-13 10:05:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1596
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/ref-met"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?