frostfs-adm refactorings #161

dstepanov-yadro · 2023-03-22T14:50:42Z

dstepanov-yadro commented

2023-03-22 14:50:42 +00:00

Drop nolint comments and fix linters for frostfs-adm

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from 5a887397d1 to 1bd7248ba0

2023-03-22 14:52:16 +00:00

Compare

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from 115491fe34 to a9435740ad

2023-03-23 06:23:24 +00:00

Compare

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from a9435740ad to 052ae9b50a

2023-03-23 06:38:43 +00:00

Compare

dstepanov-yadro changed title from ~~WIP: Refactorings~~ to frostfs-adm refactorings

2023-03-23 08:47:21 +00:00

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from 66dd320158 to 6d0a9ac70d

2023-03-23 08:48:14 +00:00

Compare

dstepanov-yadro requested review from fyrchik 2023-03-23 08:56:56 +00:00

dstepanov-yadro requested review from storage-core-committers 2023-03-23 08:57:02 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-03-23 08:57:02 +00:00

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from 6d0a9ac70d to f388355b4c

2023-03-23 13:39:09 +00:00

Compare

fyrchik approved these changes 2023-03-24 07:57:14 +00:00

cmd/frostfs-adm/internal/modules/morph/deploy.go Outdated

													
				@ -175,3 +127,4 @@

					return c.awaitTx()

				}

				func register(nnsCs *state.Contract, c *initializeContext, zone string, domain string, cs *contractState, writer *io.BufBinWriter) error {

fyrchik commented

2023-03-24 07:54:13 +00:00

Given that the package is morph, simple register seems too generic.

Given that the package is `morph`, simple `register` seems too generic.

dstepanov-yadro commented

2023-03-24 08:33:13 +00:00

Poster

fixed

fyrchik marked this conversation as resolved

cmd/frostfs-adm/internal/modules/morph/initialize.go Outdated

													
				@ -210,0 +214,4 @@

				}

				func getWallet(cmd *cobra.Command, v *viper.Viper, needContracts bool, walletDir string) (*wallet.Wallet, error) {

					if needContracts {

fyrchik commented

2023-03-24 07:56:59 +00:00

Again, what about flattening here?

if !needContracts { return "", nil }
...

Again, what about flattening here? ``` if !needContracts { return "", nil } ... ```

dstepanov-yadro commented

2023-03-24 08:33:54 +00:00

Poster

fixed

fyrchik marked this conversation as resolved

cmd/frostfs-adm/internal/modules/storagecfg/root.go Outdated

													
				@ -205,3 +220,1 @@

						p := getPath("Path to the storage directory (all available storage will be used): ")

						c.BlobstorPath = filepath.Join(p, "blob")

						c.MetabasePath = filepath.Join(p, "meta")

				func getOutputPath(args []string) string {

fyrchik commented

2023-03-24 07:49:43 +00:00

While we are here, how about flattening the structure?

if len(args) != 0 {
    return ...
}
...

While we are here, how about flattening the structure? ``` if len(args) != 0 { return ... } ... ```

dstepanov-yadro commented

2023-03-24 08:34:03 +00:00

Poster

fixed

fyrchik marked this conversation as resolved

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from f388355b4c to 6a087b0184

2023-03-24 08:32:11 +00:00

Compare

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from 6a087b0184 to a8927fc57c

2023-03-24 08:32:57 +00:00

Compare

dstepanov-yadro force-pushed refactoring/OBJECT-3610 from a8927fc57c to 479e703ce1

2023-03-24 12:11:14 +00:00

Compare

fyrchik added the due date 2023-03-27

2023-03-27 07:37:31 +00:00

acid-ant approved these changes 2023-03-27 12:13:42 +00:00

fyrchik merged commit 5bf1ec348f into master

2023-03-27 12:42:39 +00:00