TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 109 Pull requests 11 Projects Releases 2 Activity Actions

Refactor user.ID.ScriptHash() usage #1618

Merged
fyrchik merged 2 commits from elebedeva/frostfs-node:fix/sdk-user-id-scripthash into master 2025-01-30 13:18:38 +00:00
Conversation 0 Commits 2 Files changed 7 +18 -40
elebedeva commented 2025-01-28 15:57:48 +00:00
Member
Copy link

Related to TrueCloudLab/frostfs-sdk-go#302

user.ID.ScriptHash() does not return an error anymore.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Related to TrueCloudLab/frostfs-sdk-go#302 `user.ID.ScriptHash()` does not return an error anymore. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-01-28 15:57:49 +00:00
elebedeva added the
refactoring
internal
 labels 2025-01-28 15:59:02 +00:00
elebedeva changed title from Refactor user.ID.ScriptHash() usage to WIP: Refactor user.ID.ScriptHash() usage 2025-01-28 16:01:41 +00:00
elebedeva force-pushed fix/sdk-user-id-scripthash from f0e603785c to ec83958eb5 2025-01-28 16:02:42 +00:00 Compare
elebedeva force-pushed fix/sdk-user-id-scripthash from ec83958eb5 to 85f336466a 2025-01-29 14:33:20 +00:00 Compare
elebedeva changed title from WIP: Refactor user.ID.ScriptHash() usage to Refactor user.ID.ScriptHash() usage 2025-01-29 14:33:47 +00:00
dstepanov-yadro approved these changes 2025-01-29 14:48:51 +00:00
a-savchuk approved these changes 2025-01-29 14:52:12 +00:00
fyrchik approved these changes 2025-01-29 15:29:00 +00:00
pkg/services/object/ape/request_test.go Outdated
@ -20,3 +20,3 @@
const (
testOwnerID = "FPPtmAi9TCX329"
testOwnerID = "NURFM8PWbLA2aLt2vrD8q4FyfAdgESwM8y"
fyrchik commented 2025-01-29 15:28:58 +00:00
Owner
Copy link

Hm, why didn't our decoding function catch this earlier?

Hm, why didn't our decoding function catch this earlier?
elebedeva commented 2025-01-30 08:59:24 +00:00
Author
Member
Copy link

user.ID was a byte slice and user.ID.DecodeString() didn't check length and format of byte slices decoded from strings.Also, in these tests testOwnerID was used only to decode container owner id and to compare it with owner id encoded back to string.

`user.ID` was a byte slice and `user.ID.DecodeString()` didn't check length and format of byte slices decoded from strings.Also, in these tests `testOwnerID` was used only to decode container owner id and to compare it with owner id encoded back to string.
fyrchik marked this conversation as resolved
elebedeva force-pushed fix/sdk-user-id-scripthash from 85f336466a to ae851b3922 2025-01-30 11:56:04 +00:00 Compare
fyrchik merged commit 24054cf6f4 into master 2025-01-30 13:18:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
a-savchuk
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1618
No description provided.
Delete branch "elebedeva/frostfs-node:fix/sdk-user-id-scripthash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?