TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 106 Pull requests 12 Projects Releases 2 Activity Actions

Drop redundant trace_id fields from logs #1620

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/drop_trace_id_from_logs into master 2025-01-29 13:51:43 +00:00
Conversation 3 Commits 1 Files changed 24 +56 -136
dstepanov-yadro commented 2025-01-29 13:12:43 +00:00
Member
Copy link

trace_id is taken from context.

`trace_id` is taken from context.
dstepanov-yadro added 1 commit 2025-01-29 13:12:44 +00:00
[#9999] logs: Drop redundant trace_id fields
All checks were successful
DCO action / DCO (pull_request) Successful in 52s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 53s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m43s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m46s
Details
Build / Build Components (pull_request) Successful in 2m12s
Details
Tests and linters / gopls check (pull_request) Successful in 2m55s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m11s
Details
Tests and linters / Lint (pull_request) Successful in 6m1s
Details
Tests and linters / Tests (pull_request) Successful in 6m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m34s
Details
7288152d42 
`trace_id` is already taken from context.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-developers, storage-core-committers 2025-01-29 13:12:44 +00:00
dstepanov-yadro force-pushed fix/drop_trace_id_from_logs from 7288152d42 to e1a984e9d8 2025-01-29 13:14:28 +00:00 Compare
a-savchuk approved these changes 2025-01-29 13:18:45 +00:00
a-savchuk left a comment
Member
Copy link

Just wondering, why is this redundant?

Just wondering, why is this redundant?
a-savchuk commented 2025-01-29 13:19:27 +00:00
Member
Copy link

Just wondering, why is this redundant?

I've found the answer:)

> Just wondering, why is this redundant? I've found the answer:)
👍 1
achuprov approved these changes 2025-01-29 13:28:52 +00:00
fyrchik approved these changes 2025-01-29 13:47:03 +00:00
fyrchik left a comment
Owner
Copy link

<3
image

<3 ![image](/attachments/7b68e855-4c59-4294-a90a-5465f8d6e875)
image.png
3.5 KiB
fyrchik commented 2025-01-29 13:47:39 +00:00
Owner
Copy link

Have you done it with gopatch?

Have you done it with gopatch?
dstepanov-yadro commented 2025-01-29 13:51:35 +00:00
Author
Member
Copy link

Have you done it with gopatch?

No

> Have you done it with gopatch? No
dstepanov-yadro merged commit e1a984e9d8 into master 2025-01-29 13:51:43 +00:00
dstepanov-yadro deleted branch fix/drop_trace_id_from_logs 2025-01-29 13:51:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a-savchuk
achuprov
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1620
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/drop_trace_id_from_logs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?