TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 7 Projects Releases 2 Activity Actions

Cancel tree sync on errors #1621

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:tree-sync-error into master 2025-02-03 09:37:56 +00:00
Conversation 0 Commits 2 Files changed 2 +30 -16
fyrchik commented 2025-01-30 07:38:43 +00:00
Owner
Copy link
No description provided.
requested reviews from storage-core-committers, storage-core-developers 2025-01-30 07:38:43 +00:00
aarifullin reviewed 2025-01-30 09:16:59 +00:00
pkg/services/tree/sync.go Outdated
@ -168,0 +171,4 @@
select {
case merged <- ms[minTimeMoveIndex]:
case <-ctx.Done():
return minStreamedLastHeight
aarifullin commented 2025-01-30 09:16:59 +00:00
Member
Copy link

If context is done, then we may get newHeight = math.MaxUint64 + 1 -> newHeight = 0 because applyOperationStream may not return an error

https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/services/tree/sync.go#L315-L320

So, we should compare it with from to properly choose the height we start from when the next sync will come

If context is done, then we may get `newHeight = math.MaxUint64 + 1 -> newHeight = 0` because `applyOperationStream` may not return an error https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/services/tree/sync.go#L315-L320 So, we should compare it with `from` to properly choose the height we start from when the next sync will come
fyrchik commented 2025-01-30 12:31:44 +00:00
Author
Owner
Copy link

But I think it is the behaviour, that was here before this PR, it was still possible to exit with minStreamedLastHeight = math.MaxUint64, no?

But I think it is the behaviour, that was here before this PR, it was still possible to exit with `minStreamedLastHeight = math.MaxUint64`, no?
aarifullin commented 2025-01-30 13:18:28 +00:00
Member
Copy link

I believe that was incorrect from the very beginning. TBH, I don't remember the task context in details. But glancing at mergeOperationStreams I conclude it has returned MaxUint64, probably, never. So, we never reached newHeight = 0

I believe that was incorrect from the very beginning. TBH, I don't remember the task context in details. But glancing at `mergeOperationStreams` I conclude it has returned `MaxUint64`, probably, _never_. So, we never reached `newHeight = 0`
aarifullin marked this conversation as resolved
fyrchik force-pushed tree-sync-error from 85d23ddf2c to 89dd9660f7 2025-01-30 12:38:10 +00:00 Compare
acid-ant approved these changes 2025-01-31 12:18:32 +00:00
elebedeva approved these changes 2025-01-31 13:07:31 +00:00
aarifullin approved these changes 2025-02-03 09:36:53 +00:00
fyrchik merged commit 6fcae9f75a into master 2025-02-03 09:37:56 +00:00
fyrchik deleted branch tree-sync-error 2025-02-03 09:38:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
elebedeva
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1621
No description provided.
Delete branch "fyrchik/frostfs-node:tree-sync-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?